Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: add a generalisation of Dirichlet's approximation theorem #6033

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: add a generalisation of Dirichlet's approximation theorem #6033

wants to merge 10 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Jul 20, 2023 •
edited by github-actions bot

@ocfnash ocfnash added blocked-by-other-PR This PR depends on another PR which is still in the queue. awaiting-review The author would like community review of the PR new-feature Add features not present in Mathlib 3 labels Jul 20, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 22, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Jul 23, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@ocfnash ocfnash added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Jul 25, 2023
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR new-feature Add features not present in Mathlib 3 labels Aug 1, 2023
@ocfnash ocfnash added awaiting-review The author would like community review of the PR t-measure-probability Measure theory / Probability theory and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 1, 2023
@sgouezel
Copy link
Contributor

sgouezel commented Aug 1, 2023

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 1, 2023
bors bot pushed a commit that referenced this pull request Aug 1, 2023
@ocfnash
feat: add a generalisation of Dirichlet's approximation theorem (#6033)
34cd6c1
@bors
Copy link

bors bot commented Aug 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: add a generalisation of Dirichlet's approximation theorem [Merged by Bors] - feat: add a generalisation of Dirichlet's approximation theorem Aug 1, 2023
@bors bors bot closed this Aug 1, 2023
@bors bors bot deleted the ocfnash/dirichlet branch August 1, 2023 17:13
semorrison pushed a commit that referenced this pull request Aug 2, 2023
@ocfnash @semorrison
feat: add a generalisation of Dirichlet's approximation theorem (#6033)
66b690b
semorrison pushed a commit that referenced this pull request Aug 2, 2023
@ocfnash @semorrison
feat: add a generalisation of Dirichlet's approximation theorem (#6033)
1df024b
semorrison pushed a commit that referenced this pull request Aug 3, 2023
@ocfnash @semorrison
feat: add a generalisation of Dirichlet's approximation theorem (#6033)
b88b1fb
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@ocfnash @semorrison
feat: add a generalisation of Dirichlet's approximation theorem (#6033)
5c53be2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocfnash @leanprover-community-mathlib4-bot @sgouezel