[Merged by Bors] - feat: port Data.PNat.Defs #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruben-VandeVelde
force-pushed
the
pnat
branch
from
d232407
to
fd3a994
Compare
digama0
reviewed
Nov 15, 2022
semorrison
reviewed
Nov 16, 2022
semorrison
reviewed
Nov 16, 2022
semorrison
added
the
awaiting-author
Vierkantor
added
awaiting-review
semorrison
reviewed
Nov 17, 2022
Comment on lines
+278
to
+279
| /- | ||
| section CanLift |
There was a problem hiding this comment.
Can we have a -- Porting note: explaining why these are commented out?
|
bors d+ |
|
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |
semorrison
added
delegated
and removed
awaiting-review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
First attempt - I hope it's going in the right direction ported from [70fd9563a21e7b963887c9360bd29b2393e6225a](leanprover-community/mathlib@70fd956) (technically from an earlier commit, but it hasn't changed since)
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt - I hope it's going in the right direction
ported from 70fd9563a21e7b963887c9360bd29b2393e6225a
(technically from an earlier commit, but it hasn't changed since)