Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor: rename FreeProduct to Monoid.CoprodI #6055

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - refactor: rename FreeProduct to Monoid.CoprodI #6055

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 22, 2023

Should it be CoprodI or ICoprod?

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Jul 22, 2023
@urkud urkud requested a review from eric-wieser July 22, 2023 13:17
@ocfnash
Copy link
Contributor

ocfnash commented Jul 31, 2023

What is the motivation for this renaming?

Would moving FreeProduct into the Monoid namespace achieve the same aims?

@urkud
Copy link
Member Author

urkud commented Jul 31, 2023 •
edited

What is the motivation for this renaming?

Would moving FreeProduct into the Monoid namespace achieve the same aims?

See leanprover-community/mathlib#18437.
I'm going to add a Prod version and in that mathlib 3 PR I was told to use Coprod/Coprodᵢ (it was before we renamed Unionᵢ to iUnion).
I'm happy with any naming convention that will allow both indexed and non-indexed version.

@ocfnash
Copy link
Contributor

ocfnash commented Jul 31, 2023

OK thanks, let's go with this as it is.

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 31, 2023
bors bot pushed a commit that referenced this pull request Jul 31, 2023
@urkud
refactor: rename FreeProduct to Monoid.CoprodI (#6055)
15677dd
@bors
Copy link

bors bot commented Jul 31, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor: rename FreeProduct to Monoid.CoprodI [Merged by Bors] - refactor: rename FreeProduct to Monoid.CoprodI Jul 31, 2023
@bors bors bot closed this Jul 31, 2023
@bors bors bot deleted the YK-monoid-coprod branch July 31, 2023 15:31
semorrison pushed a commit that referenced this pull request Aug 2, 2023
@urkud @semorrison
refactor: rename FreeProduct to Monoid.CoprodI (#6055)
a70e9fd
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@urkud @semorrison
refactor: rename FreeProduct to Monoid.CoprodI (#6055)
3fe6968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocfnash ocfnash ocfnash left review comments

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @ocfnash