Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: multiplication on the right preserves left invariant measures #6071

Closed
wants to merge 58 commits into from

Conversation

atarnoam
Copy link
Collaborator

@atarnoam atarnoam commented Jul 23, 2023

The image of a left invariant measure under right addition is left invariant, and if the measure was a Haar measure it is
stays a Haar measure.


Open in Gitpod

Komyyy
Komyyy previously requested changes Jul 24, 2023
Mathlib/MeasureTheory/Group/Measure.lean Outdated Show resolved Hide resolved
atarnoam and others added 2 commits July 24, 2023 16:48
Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
@atarnoam atarnoam requested a review from urkud July 27, 2023 13:33
@atarnoam atarnoam self-assigned this Jul 27, 2023
@atarnoam atarnoam added the awaiting-review The author would like community review of the PR label Jul 27, 2023
@atarnoam atarnoam requested a review from kbuzzard July 29, 2023 10:01
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me but I'm not an expert in this part of the library. I left a couple of minor comments. Thanks for the PR!

Mathlib/MeasureTheory/Group/Measure.lean Outdated Show resolved Hide resolved
Mathlib/MeasureTheory/Group/Measure.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes t-measure-probability Measure theory / Probability theory and removed awaiting-review The author would like community review of the PR labels Aug 1, 2023
@atarnoam atarnoam added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 1, 2023
@atarnoam
Copy link
Collaborator Author

atarnoam commented Aug 3, 2023

Hey, it's been two weeks since the last review @eric-wieser @Komyyy. Mind giving the PR another look?

eric-wieser and others added 2 commits August 3, 2023 15:14
Copy link
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Here are the last few nitpicks, please merge this after fixing them and checking that everything compiles.

bors d+

Mathlib/MeasureTheory/Group/Measure.lean Outdated Show resolved Hide resolved
Mathlib/MeasureTheory/Group/Measure.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 7, 2023

✌️ atarnoam can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Sep 7, 2023
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@atarnoam
Copy link
Collaborator Author

atarnoam commented Sep 7, 2023

bors r+

bors bot pushed a commit that referenced this pull request Sep 7, 2023
…6071)

The image of a left invariant measure under right addition is left invariant, and if the measure was a Haar measure it is
stays a Haar measure.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Sep 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: multiplication on the right preserves left invariant measures [Merged by Bors] - feat: multiplication on the right preserves left invariant measures Sep 7, 2023
@bors bors bot closed this Sep 7, 2023
@bors bors bot deleted the feature/modular-func branch September 7, 2023 21:47
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
…6071)

The image of a left invariant measure under right addition is left invariant, and if the measure was a Haar measure it is
stays a Haar measure.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants