Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: make an ideal lemma more constructive #6080

Closed
wants to merge 1 commit into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Jul 23, 2023

This generalizes Ideal.pow_multiset_sum_mem_span_pow away from Classical.decEq.


Open in Gitpod

See if this changes anything

@kbuzzard kbuzzard added the WIP Work in progress label Jul 23, 2023
@kbuzzard
Copy link
Member Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 8458687.Found no runs to compare against.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@bors
Copy link

bors bot commented Jul 24, 2023

✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser eric-wieser changed the title fix: make ideals more constructive fix: make an ideal lemma more constructive Jul 24, 2023
@kbuzzard kbuzzard added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jul 25, 2023
@kbuzzard
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 25, 2023
This generalizes `Ideal.pow_multiset_sum_mem_span_pow` away from `Classical.decEq`.
@bors
Copy link

bors bot commented Jul 25, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: make an ideal lemma more constructive [Merged by Bors] - fix: make an ideal lemma more constructive Jul 25, 2023
@bors bors bot closed this Jul 25, 2023
@bors bors bot deleted the kbuzzard-constructive-ideal branch July 25, 2023 18:01
semorrison pushed a commit that referenced this pull request Aug 14, 2023
This generalizes `Ideal.pow_multiset_sum_mem_span_pow` away from `Classical.decEq`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review The author would like community review of the PR delegated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants