Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port rbtree.init #611

Closed
wants to merge 7 commits into from
Closed

Conversation

arienmalec
Copy link
Collaborator

@arienmalec arienmalec commented Nov 16, 2022

Initial port, covers most of the renaming and syntax. Need help with unsupported tactics/options for RBTree.

Made against 8c53048add6ffacdda0b36c4917bfe37e209b0ba

@arienmalec arienmalec added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Nov 16, 2022
@arienmalec
Copy link
Collaborator Author

arienmalec commented Nov 16, 2022

[deleted -- was mistaken definition in port]

@Ruben-VandeVelde
Copy link
Collaborator

Is this even used outside tactics / will tactics use this implementation or the one in std4?

@arienmalec
Copy link
Collaborator Author

arienmalec commented Nov 16, 2022

Ah, there's an RBMap in std4! Would be far better to make the port use that...

It's transitively included in data.tree, which spawns various dependencies.

@semorrison
Copy link
Contributor

Sorry to waste your time on this, but yes, let's ditch this in favour of RBMap.

@semorrison semorrison closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants