Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: shorter names for some instances #6123

Closed
wants to merge 6 commits into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Jul 25, 2023


Open in Gitpod

This is two changes.

  1. Firstly I manually name some instances (because I am debugging some tensor product stuff and it's getting annoying). For example

Algebra.TensorProduct.instCommRingTensorProductToCommSemiringToAddCommMonoidToNonUnitalNonAssocSemiringToNonUnitalNonAssocRingToNonAssocRingToRingToAddCommMonoidToNonUnitalNonAssocSemiringToNonUnitalNonAssocRingToNonAssocRingToRingToModuleToSemiringToCommSemiringToModuleToSemiringToCommSemiring : CommRing (A ⊗[R] B)

now becomes Algebra.TensorProduct.InstCommRing : CommRing (A ⊗[R] B)

  1. toRing := blah generates a slightly less convoluted term than blah: ring with.

@kbuzzard kbuzzard added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 25, 2023
@kbuzzard kbuzzard removed the awaiting-review The author would like community review of the PR label Jul 25, 2023
@kbuzzard kbuzzard added the awaiting-review The author would like community review of the PR label Jul 25, 2023
@kbuzzard kbuzzard added awaiting-review The author would like community review of the PR and removed awaiting-review The author would like community review of the PR labels Jul 25, 2023
docs/overview.yaml Outdated Show resolved Hide resolved
@mcdoll
Copy link
Member

mcdoll commented Jul 25, 2023

thanks!
maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by mcdoll.

@Vierkantor
Copy link
Contributor

LGTM, thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 25, 2023
bors bot pushed a commit that referenced this pull request Jul 25, 2023
@bors
Copy link

bors bot commented Jul 25, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: shorter names for some instances [Merged by Bors] - fix: shorter names for some instances Jul 25, 2023
@bors bors bot closed this Jul 25, 2023
@bors bors bot deleted the kbuzzard-rename-instances branch July 25, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants