Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Analysis): add WithLp for products #6136

Closed
wants to merge 48 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Jul 25, 2023

The file NormedSpace.ProdLp is copied from NormedSpace.PiLp with a two changes

  • For p = 0 we define the distance by using and if-else block which in turn makes it necessary to add some classicality assumptions
  • We omit the sections about basis and constant maps

The file InnerProductSpace.ProdL2 will contain more things later on, this is also why I imported InnerProductSpace.Projection since for the adjoint I need the properties of the orthogonal complement on products.

Open in Gitpod

@mcdoll mcdoll added WIP Work in progress t-analysis Analysis (normed *, calculus) labels Jul 25, 2023
@mcdoll mcdoll added awaiting-review and removed WIP Work in progress labels Aug 5, 2023
@j-loreaux
Copy link
Collaborator

I think it would be good to wait until #6409 is merged (or else thrown out), but I'll have an in-depth look after that.

bors bot pushed a commit that referenced this pull request Aug 14, 2023
The motivation is to be able to reuse this for `ProdLp` in #6136.

This matches the pattern of how the `Lex` type synonym is used.
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:25
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:14
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Sep 26, 2023
@j-loreaux
Copy link
Collaborator

j-loreaux commented Sep 26, 2023

@mcdoll if you make this build I am ready to merge it, but please merge master first.

@eric-wieser
Copy link
Member

@j-loreaux, I'm not sure how to rectify that comment with your comment above. Do you want to see the L2 lemmas moved back first, or are you happy to merge it either way?

@j-loreaux
Copy link
Collaborator

Sorry, that was unclear. I'm ready to merge it modulo moving the lemmas back.

@mcdoll mcdoll added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 28, 2023
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@bors
Copy link

bors bot commented Sep 29, 2023

✌️ mcdoll can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mcdoll
Copy link
Member Author

mcdoll commented Sep 29, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 29, 2023
The file `NormedSpace.ProdLp` is copied from `NormedSpace.PiLp` with a two changes
- For `p = 0` we define the distance by using and if-else block which in turn makes it necessary to add some classicality assumptions
- We omit the sections about basis and constant maps



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Sep 29, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Analysis): add WithLp for products [Merged by Bors] - feat(Analysis): add WithLp for products Sep 29, 2023
@bors bors bot closed this Sep 29, 2023
@bors bors bot deleted the mcdoll/inner_prod_prod branch September 29, 2023 15:19
mathlib-bors bot pushed a commit that referenced this pull request Nov 9, 2023
The current definition of the distance in `piLp` uses the distance for `p > 0`, but avoids it for `p = 0`. We change the definition for `p = 0` to also have it in terms of the distance, to make sure it is reasonable even when one uses non-Hausdorff spaces.This matches what has been done for `prodLp` in #6136.
grunweg pushed a commit that referenced this pull request Dec 15, 2023
The current definition of the distance in `piLp` uses the distance for `p > 0`, but avoids it for `p = 0`. We change the definition for `p = 0` to also have it in terms of the distance, to make sure it is reasonable even when one uses non-Hausdorff spaces.This matches what has been done for `prodLp` in #6136.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants