Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Topology/Order/NhdsSet): new file #6161

Closed
wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 26, 2023

Prove lemmas about neighborhoods of intervals.

Some lemmas are TC-generalizations
of lemmas from the Sphere Eversion Project.


I'm adding more lemmas

Open in Gitpod

Prove lemmas about neighborhoods of intervals.
@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels Jul 26, 2023
Comment on lines 59 to 60
theorem Ici_mem_nhdsSet_Ici (h : a < b) : Ici a ∈ 𝓝ˢ (Ici b) :=
mem_of_superset (Ioi_mem_nhdsSet_Ici.2 h) Ioi_subset_Ici_self
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be an iff in the order topology, right? I don't want you to add it, but that makes me think that the naming of these could get quickly inconsistent. I can think of two options:

  • add _iff to the iff lemmas, and add aliases for the backwards directions with the current names
  • add of_lt to the ones which aren't iff, and add aliases for backwards directions of iffs with of_lt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added _iff to the iff lemmas. The Ici_mem_nhdsSet_Ici is not an iff in the order topology, e.g., for a = b = 0 in Nat.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right we would probably need NoBotOrder for it to work.

Copy link
Member

@ADedecker ADedecker Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually you proved it at the end of the file, perfect. EDIT: and indeed, the condition that I mentioned is not enough, you have the right one.

Mathlib/Topology/Order/NhdsSet.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Order/NhdsSet.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Order/NhdsSet.lean Outdated Show resolved Hide resolved
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 28, 2023
urkud and others added 2 commits July 29, 2023 00:29
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 29, 2023
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 30, 2023
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 30, 2023
@ADedecker
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 31, 2023
bors bot pushed a commit that referenced this pull request Jul 31, 2023
Prove lemmas about neighborhoods of intervals.

Some lemmas are TC-generalizations
of lemmas from the Sphere Eversion Project.
@bors
Copy link

bors bot commented Jul 31, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Topology/Order/NhdsSet): new file [Merged by Bors] - feat(Topology/Order/NhdsSet): new file Jul 31, 2023
@bors bors bot closed this Jul 31, 2023
@bors bors bot deleted the YK-ord-nhdsset branch July 31, 2023 08:59
urkud added a commit to leanprover-community/sphere-eversion that referenced this pull request Jul 31, 2023
PRd lemmas under different names to Mathlib
in leanprover-community/mathlib4#6161
semorrison pushed a commit that referenced this pull request Aug 2, 2023
Prove lemmas about neighborhoods of intervals.

Some lemmas are TC-generalizations
of lemmas from the Sphere Eversion Project.
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Prove lemmas about neighborhoods of intervals.

Some lemmas are TC-generalizations
of lemmas from the Sphere Eversion Project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants