[Merged by Bors] - chore: split RingTheory/TensorProduct
#6187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a reasonably-sized section on modules over two rings before we actual reach tensor products of rings.
eric-wieser
added
awaiting-review
3 tasks
eric-wieser
commented
Jul 27, 2023
Comment on lines
+30
to
+34
| ## Implementation notes | ||
|
|
||
| We could thus consider replacing the less general definitions with these ones. If we do this, we | ||
| probably should still implement the less general ones as abbreviations to the more general ones with | ||
| fewer type arguments. |
There was a problem hiding this comment.
This note is just copied from the other file: it's maybe still a good idea, but I didn't want to attempt it yet as it interferes with some other refactors I have in progress.
kbuzzard
reviewed
Jul 27, 2023
|
|
2 tasks
|
!maintainer merge |
|
maintainer merge (! is only for bench) |
|
🚀 Pull request has been placed on the maintainer queue by eric-wieser. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
There is a reasonably-sized section on modules over two rings before we actual reach tensor products of rings. The motivation for splitting here is to make room for the results in #6035. The declarations are copied without modification, the module docstring has been adapted.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
RingTheory/TensorProductRingTheory/TensorProduct
adomani
pushed a commit
that referenced
this pull request
Jul 28, 2023
There is a reasonably-sized section on modules over two rings before we actual reach tensor products of rings. The motivation for splitting here is to make room for the results in #6035. The declarations are copied without modification, the module docstring has been adapted.
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
There is a reasonably-sized section on modules over two rings before we actual reach tensor products of rings. The motivation for splitting here is to make room for the results in #6035. The declarations are copied without modification, the module docstring has been adapted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a reasonably-sized section on modules over two rings before we actual reach tensor products of rings.
The motivation for splitting here is to make room for the results in #6035.
The declarations are copied without modification, the module docstring has been adapted.