Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: patch for std4#197 (More add lemmas for Nat) #6202

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - fix: patch for std4#197 (More add lemmas for Nat) #6202

wants to merge 5 commits into from

Conversation

fgdorais
Copy link
Collaborator

@fgdorais fgdorais commented Jul 28, 2023 •
edited

@fgdorais fgdorais added WIP Work in progress t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-algebra Algebra (groups, rings, fields etc) blocked-by-std-PR This PR depends on a PR in Std labels Jul 28, 2023
@fgdorais fgdorais mentioned this pull request Jul 24, 2023
Merged
1 task
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jul 28, 2023
@fgdorais fgdorais changed the title feat: patch for std4#197 fix: patch for std4#197 Jul 28, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Aug 7, 2023
@fgdorais fgdorais changed the title fix: patch for std4#197 fix: patch for std4#197 (More add lemmas for Nat) Aug 21, 2023
semorrison
semorrison approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here all look reasonable to me, I would be happy to merge once the Std commit lands and this is updated to master.

@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:25
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:14
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 1, 2023
@fgdorais fgdorais force-pushed the fgdorais-nat-add branch 3 times, most recently from 6000734 to 636a14b Compare November 1, 2023 02:49
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 2, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 21, 2023
@fgdorais fgdorais force-pushed the fgdorais-nat-add branch 3 times, most recently from 024a791 to 30448cd Compare November 21, 2023 12:07
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 21, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 21, 2023
@semorrison
Copy link
Contributor

bors d+

(Obivously it will need to wait for Std.)

@mathlib-bors
Copy link

mathlib-bors bot commented Nov 23, 2023

✌️ fgdorais can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 26, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 7, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Dec 8, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@fgdorais fgdorais removed t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-algebra Algebra (groups, rings, fields etc) blocked-by-std-PR This PR depends on a PR in Std labels Dec 8, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 8, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 8, 2023
@fgdorais
Copy link
Collaborator Author

fgdorais commented Dec 8, 2023

bors r+

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 8, 2023

👎 Rejected by label

@fgdorais fgdorais added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 8, 2023
@fgdorais
Copy link
Collaborator Author

fgdorais commented Dec 8, 2023

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 8, 2023
@fgdorais
fix: patch for std4#197 (More add lemmas for Nat) (#6202)
d76f152
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 8, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: patch for std4#197 (More add lemmas for Nat) [Merged by Bors] - fix: patch for std4#197 (More add lemmas for Nat) Dec 8, 2023
@mathlib-bors mathlib-bors bot closed this Dec 8, 2023
@mathlib-bors mathlib-bors bot deleted the fgdorais-nat-add branch December 8, 2023 22:49
@eric-wieser eric-wieser mentioned this pull request Dec 8, 2023
Closed
3 tasks
@fgdorais fgdorais mentioned this pull request Dec 8, 2023
Closed
mathlib-bors bot pushed a commit that referenced this pull request Dec 9, 2023
@fgdorais
fix: bad lakefile from #6202 (#8914)
b46b244
awueth pushed a commit that referenced this pull request Dec 19, 2023
@fgdorais @awueth
fix: patch for std4#197 (More add lemmas for Nat) (#6202)
e3d665e
awueth pushed a commit that referenced this pull request Dec 19, 2023
@fgdorais @awueth
fix: bad lakefile from #6202 (#8914)
4b16894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison approved these changes

Assignees
No one assigned
Labels
awaiting-review The author would like community review of the PR delegated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgdorais @semorrison @leanprover-community-mathlib4-bot