Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(Topology/ContinuousFunction/Algebra): lattice ordered group gives inf/sup formula #6205

Closed
wants to merge 11 commits into from

Conversation

mans0954
Copy link
Collaborator

Previously the following comment occured in Topology.ContinuousFunction.Algebra:

-- TODO:
-- This lemma (and the next) could go all the way back in Algebra.Order.Field,
-- except that it is tedious to prove without tactics.
-- Rather than stranding it at some intermediate location,
-- it's here, immediately prior to the point of use.

Subsequently, the theory of lattice ordered groups has been developed in Mathlib (Algebra.Order.LatticeGroup). This now provides the natural "intermediate location" for these lemmas, they are an immediate consequence of LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub and LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub. In fact we can show that C(α, β) is itself a lattice ordered group and hence expressions for the inf and sup (inf_eq and sup_eq) can be deduced directly from LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub and LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub.

This was previously submitted to Mathlib leanprover-community/mathlib#18780


Open in Gitpod

@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 28, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semorrison, I think you might have written the inf_eq lemma; does this look good to you?

@mans0954 mans0954 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 28, 2023
@j-loreaux
Copy link
Collaborator

This looks fine to me also. The inf_eq and sup_eq lemmas are easily obtained from the more general versions now, so I don't see any reason not to merge as is.

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 1, 2023
bors bot pushed a commit that referenced this pull request Aug 1, 2023
…gives inf/sup formula (#6205)

Previously the following comment occured in `Topology.ContinuousFunction.Algebra`:

> -- TODO:
-- This lemma (and the next) could go all the way back in `Algebra.Order.Field`,
-- except that it is tedious to prove without tactics.
-- Rather than stranding it at some intermediate location,
-- it's here, immediately prior to the point of use.

Subsequently, the theory of lattice ordered groups has been developed in Mathlib (Algebra.Order.LatticeGroup). This now provides the natural "intermediate location" for these lemmas, they are an immediate consequence of `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`. In fact we can show that `C(α, β)` is itself a lattice ordered group and hence expressions for the `inf` and `sup` (`inf_eq` and `sup_eq`) can be deduced directly from `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`.

This was previously submitted to Mathlib leanprover-community/mathlib#18780



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
@bors
Copy link

bors bot commented Aug 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor(Topology/ContinuousFunction/Algebra): lattice ordered group gives inf/sup formula [Merged by Bors] - refactor(Topology/ContinuousFunction/Algebra): lattice ordered group gives inf/sup formula Aug 1, 2023
@bors bors bot closed this Aug 1, 2023
@bors bors bot deleted the mans0954/continuous-maps-lattice-ordered-group branch August 1, 2023 21:10
semorrison pushed a commit that referenced this pull request Aug 2, 2023
…gives inf/sup formula (#6205)

Previously the following comment occured in `Topology.ContinuousFunction.Algebra`:

> -- TODO:
-- This lemma (and the next) could go all the way back in `Algebra.Order.Field`,
-- except that it is tedious to prove without tactics.
-- Rather than stranding it at some intermediate location,
-- it's here, immediately prior to the point of use.

Subsequently, the theory of lattice ordered groups has been developed in Mathlib (Algebra.Order.LatticeGroup). This now provides the natural "intermediate location" for these lemmas, they are an immediate consequence of `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`. In fact we can show that `C(α, β)` is itself a lattice ordered group and hence expressions for the `inf` and `sup` (`inf_eq` and `sup_eq`) can be deduced directly from `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`.

This was previously submitted to Mathlib leanprover-community/mathlib#18780



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
semorrison pushed a commit that referenced this pull request Aug 2, 2023
…gives inf/sup formula (#6205)

Previously the following comment occured in `Topology.ContinuousFunction.Algebra`:

> -- TODO:
-- This lemma (and the next) could go all the way back in `Algebra.Order.Field`,
-- except that it is tedious to prove without tactics.
-- Rather than stranding it at some intermediate location,
-- it's here, immediately prior to the point of use.

Subsequently, the theory of lattice ordered groups has been developed in Mathlib (Algebra.Order.LatticeGroup). This now provides the natural "intermediate location" for these lemmas, they are an immediate consequence of `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`. In fact we can show that `C(α, β)` is itself a lattice ordered group and hence expressions for the `inf` and `sup` (`inf_eq` and `sup_eq`) can be deduced directly from `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`.

This was previously submitted to Mathlib leanprover-community/mathlib#18780



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
semorrison pushed a commit that referenced this pull request Aug 3, 2023
…gives inf/sup formula (#6205)

Previously the following comment occured in `Topology.ContinuousFunction.Algebra`:

> -- TODO:
-- This lemma (and the next) could go all the way back in `Algebra.Order.Field`,
-- except that it is tedious to prove without tactics.
-- Rather than stranding it at some intermediate location,
-- it's here, immediately prior to the point of use.

Subsequently, the theory of lattice ordered groups has been developed in Mathlib (Algebra.Order.LatticeGroup). This now provides the natural "intermediate location" for these lemmas, they are an immediate consequence of `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`. In fact we can show that `C(α, β)` is itself a lattice ordered group and hence expressions for the `inf` and `sup` (`inf_eq` and `sup_eq`) can be deduced directly from `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`.

This was previously submitted to Mathlib leanprover-community/mathlib#18780



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
…gives inf/sup formula (#6205)

Previously the following comment occured in `Topology.ContinuousFunction.Algebra`:

> -- TODO:
-- This lemma (and the next) could go all the way back in `Algebra.Order.Field`,
-- except that it is tedious to prove without tactics.
-- Rather than stranding it at some intermediate location,
-- it's here, immediately prior to the point of use.

Subsequently, the theory of lattice ordered groups has been developed in Mathlib (Algebra.Order.LatticeGroup). This now provides the natural "intermediate location" for these lemmas, they are an immediate consequence of `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`. In fact we can show that `C(α, β)` is itself a lattice ordered group and hence expressions for the `inf` and `sup` (`inf_eq` and `sup_eq`) can be deduced directly from `LatticeOrderedCommGroup.two_inf_eq_add_sub_abs_sub` and `LatticeOrderedCommGroup.two_sup_eq_add_add_abs_sub`.

This was previously submitted to Mathlib leanprover-community/mathlib#18780



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants