-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(Algebra/Module/LinearMap): generalize the endomorphism algebra instance #6207
Conversation
…ra instance This also moves some lemmas about `IsUnit (_ : Module.End R M)` to an earlier file as they are nothing to do with `Algebra`.
I will try to make some time to do reviewing in the next days! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors r+
…ra instance (#6207) Note that the module instance was already generalized; we were just missing the fact that when combined with the existing ring instance, the result was an algebra. This also moves some lemmas about `IsUnit (_ : Module.End R M)` to an earlier file as they are nothing to do with `Algebra`.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
…ra instance (#6207) Note that the module instance was already generalized; we were just missing the fact that when combined with the existing ring instance, the result was an algebra. This also moves some lemmas about `IsUnit (_ : Module.End R M)` to an earlier file as they are nothing to do with `Algebra`.
…ra instance (#6207) Note that the module instance was already generalized; we were just missing the fact that when combined with the existing ring instance, the result was an algebra. This also moves some lemmas about `IsUnit (_ : Module.End R M)` to an earlier file as they are nothing to do with `Algebra`.
Note that the module instance was already generalized; we were just missing the fact that when combined with the existing ring instance, the result was an algebra.
This also moves some lemmas about
IsUnit (_ : Module.End R M)
to an earlier file as they are nothing to do withAlgebra
.