Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: golf using compute_degree #6222

Closed
wants to merge 37 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jul 28, 2023

This PR is a companion to #6221. It uses the tactic compute_degree to golf two proofs and restore a proof closer to its mathlib3 version.


Open in Gitpod

@semorrison
Copy link
Contributor

(Just a reminder that on the mathlib4 repo, if authors don't self-label with awaiting-review, PRs don't appear on the #queue and might never be noticed. :-)

@adomani
Copy link
Collaborator Author

adomani commented Aug 6, 2023

Scott, thanks for the heads up! I'll add the dependency on the PR with the tactic and also add the awaiting-review label, then!

@adomani adomani added the awaiting-review The author would like community review of the PR label Aug 6, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Aug 6, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Sep 2, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 2, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Sep 6, 2023
bors bot pushed a commit that referenced this pull request Sep 6, 2023
This PR is a companion to #6221.  It uses the tactic `compute_degree` to golf two proofs and restore a proof closer to its mathlib3 version.
@bors
Copy link

bors bot commented Sep 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: golf using compute_degree [Merged by Bors] - chore: golf using compute_degree Sep 6, 2023
@bors bors bot closed this Sep 6, 2023
@bors bors bot deleted the adomani_cd_golf branch September 6, 2023 10:13
ebab pushed a commit that referenced this pull request Sep 11, 2023
This PR is a companion to #6221.  It uses the tactic `compute_degree` to golf two proofs and restore a proof closer to its mathlib3 version.
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
This PR is a companion to #6221.  It uses the tactic `compute_degree` to golf two proofs and restore a proof closer to its mathlib3 version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants