-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: IsROrC Rank Lemmas without PartialOrder and StarOrderedRing #6239
Conversation
Please change the PR title, this should start with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these results are necessary. #6391 will be merged soon, and then these results will be available behind the ComplexOrder
scope.
@@ -8,6 +8,7 @@ import Mathlib.LinearAlgebra.Matrix.ToLin | |||
import Mathlib.LinearAlgebra.FiniteDimensional | |||
import Mathlib.LinearAlgebra.Matrix.DotProduct | |||
import Mathlib.Data.Complex.Module | |||
import Mathlib.Data.IsROrC.Basic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too heavy an import for this file. If you need it, it means the results don't belong here.
@@ -6,6 +6,7 @@ Authors: Johannes Hölzl, Patrick Massot, Casper Putz, Anne Baanen | |||
import Mathlib.Algebra.Star.Order | |||
import Mathlib.Data.Matrix.Basic | |||
import Mathlib.LinearAlgebra.StdBasis | |||
import Mathlib.Data.IsROrC.Basic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, too heavy an import
@[simp, isROrC_simps] | ||
theorem re_sum (f : n → K) : IsROrC.re (∑ i in s, f i) = ∑ i in s, IsROrC.re (f i) := by | ||
apply map_sum _ _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary since it is just map_sum IsROrC.reLm _
.
I see. Anyway I think I will close this PR for now. |
Whether or not an import is "too heavy" or not is a bit subjective. However, the basic question is: are you importing (even transitively) a lot more than was imported previously? If so, is it essential to the file, or only a few declarations? If the latter, then probably it's too heavy. If it is essential for a lot of new material you are adding, maybe it deserves its own new file. |
This PR proves three lemmas$\mathbb{R}$ or $\mathbb{C}$ fields:
rank_conjTranspose_R_or_C
,rank_self_mul_conjTranspose_R_or_C
andrank_conjTranspose_mul_self_R_or_C
which state that inThese are almost the same named lemmas (without R_or_C suffix). However the original lemmas don't apply without using a
PartialOrder
andStarOrderedRing
on the Complex Field andIsROrC
, which seems to be a point the community is still discussing. The lemmas in this PR apply directly WITHOUT requiringPartialOrder
andStarOrderedRing
.Co-authored-by: Mohanad Ahmed m.a.m.elhassan@gmail.com