Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: allow differential objects with shifts in an AddMonoidWithOne #6246

Closed
wants to merge 5 commits into from

Conversation

semorrison
Copy link
Contributor

What I was really hoping to do was show that ℕ-graded DGOs were the same as ℕ-graded chain complexes (we have the ℤ version), but this still seems awkward. If anyone would like to help with that, please let me know. I think this might be helpful in constructor tensor products of chain complexes with less suffering.


Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI labels Jul 30, 2023
@TwoFX TwoFX added the t-category-theory Category theory label Jul 30, 2023
Mathlib/CategoryTheory/DifferentialObject.lean Outdated Show resolved Hide resolved
Mathlib/CategoryTheory/DifferentialObject.lean Outdated Show resolved Hide resolved
Mathlib/CategoryTheory/DifferentialObject.lean Outdated Show resolved Hide resolved
Mathlib/CategoryTheory/DifferentialObject.lean Outdated Show resolved Hide resolved
@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 30, 2023
Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 30, 2023
Mathlib/CategoryTheory/DifferentialObject.lean Outdated Show resolved Hide resolved
Mathlib/CategoryTheory/DifferentialObject.lean Outdated Show resolved Hide resolved
Mathlib/CategoryTheory/DifferentialObject.lean Outdated Show resolved Hide resolved
@TwoFX
Copy link
Member

TwoFX commented Jul 30, 2023

bors d+

@bors
Copy link

bors bot commented Jul 30, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jul 30, 2023
Co-authored-by: Markus Himmel <markus@himmel-villmar.de>
@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 30, 2023
bors bot pushed a commit that referenced this pull request Jul 30, 2023
…6246)

What I was really hoping to do was show that ℕ-graded DGOs were the same as ℕ-graded chain complexes (we have the ℤ version), but this still seems awkward. If anyone would like to help with that, please let me know. I think this might be helpful in constructor tensor products of chain complexes with less suffering.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jul 30, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: allow differential objects with shifts in an AddMonoidWithOne [Merged by Bors] - feat: allow differential objects with shifts in an AddMonoidWithOne Jul 30, 2023
@bors bors bot closed this Jul 30, 2023
@bors bors bot deleted the differential_object_shift branch July 30, 2023 23:56
semorrison added a commit that referenced this pull request Aug 2, 2023
…6246)

What I was really hoping to do was show that ℕ-graded DGOs were the same as ℕ-graded chain complexes (we have the ℤ version), but this still seems awkward. If anyone would like to help with that, please let me know. I think this might be helpful in constructor tensor products of chain complexes with less suffering.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
semorrison added a commit that referenced this pull request Aug 14, 2023
…6246)

What I was really hoping to do was show that ℕ-graded DGOs were the same as ℕ-graded chain complexes (we have the ℤ version), but this still seems awkward. If anyone would like to help with that, please let me know. I think this might be helpful in constructor tensor products of chain complexes with less suffering.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants