Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Data/Set): add 2 @[simp] attrs #6251

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(Data/Set): add 2 @[simp] attrs #6251

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 30, 2023 •
edited by eric-wieser

The corresponding Finset lemmas are already marked simp.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI labels Jul 30, 2023
eric-wieser
eric-wieser approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the corresponding Finset lemmas already marked simp?

@urkud
Copy link
Member Author

urkud commented Jul 31, 2023

Are the corresponding Finset lemmas already marked simp?

Yes, see https://leanprover-community.github.io/mathlib4_docs/Mathlib/Data/Finset/Prod.html#Finset.nonempty_product

@eric-wieser
Copy link
Member

bors merge

Thanks! I added that information to the description

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 31, 2023
bors bot pushed a commit that referenced this pull request Jul 31, 2023
@urkud
chore(Data/Set): add 2 @[simp] attrs (#6251)
ff2de95 
The corresponding `Finset` lemmas are already marked `simp`.
@bors
Copy link

bors bot commented Jul 31, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Data/Set): add 2 @[simp] attrs [Merged by Bors] - chore(Data/Set): add 2 @[simp] attrs Jul 31, 2023
@bors bors bot closed this Jul 31, 2023
@bors bors bot deleted the YK-prod-simp branch July 31, 2023 18:22
semorrison pushed a commit that referenced this pull request Aug 2, 2023
@urkud @semorrison
chore(Data/Set): add 2 @[simp] attrs (#6251)
d0277da 
The corresponding `Finset` lemmas are already marked `simp`.
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@urkud @semorrison
chore(Data/Set): add 2 @[simp] attrs (#6251)
3ce9845 
The corresponding `Finset` lemmas are already marked `simp`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @eric-wieser