Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Data/Polynomial/Basic): golf & make some variables implicit #6270

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(Data/Polynomial/Basic): golf & make some variables implicit #6270

wants to merge 2 commits into from

Conversation

FR-vdash-bot
Copy link
Collaborator

Open in Gitpod

@semorrison semorrison added the t-algebra Algebra (groups, rings, fields etc) label Aug 6, 2023
@kbuzzard
Copy link
Member

kbuzzard commented Aug 9, 2023

LGTM

@RemyDegenne
Copy link
Contributor

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Aug 10, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Aug 10, 2023
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge This PR has been sent to bors. labels Aug 16, 2023
@eric-wieser
Copy link
Member

bors d+

Please resolve the conflicts (Type _ should be Type*)

@bors
Copy link

bors bot commented Aug 16, 2023

✌️ negiizhao can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@FR-vdash-bot FR-vdash-bot added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Aug 20, 2023
@FR-vdash-bot
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Aug 20, 2023
@FR-vdash-bot
chore(Data/Polynomial/Basic): golf & make some variables implicit (#6270
e75cfd1 
)
@bors
Copy link

bors bot commented Aug 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Data/Polynomial/Basic): golf & make some variables implicit [Merged by Bors] - chore(Data/Polynomial/Basic): golf & make some variables implicit Aug 20, 2023
@bors bors bot closed this Aug 20, 2023
@bors bors bot deleted the FR_polynomial_sum branch August 20, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@FR-vdash-bot @kbuzzard @RemyDegenne @eric-wieser @semorrison @leanprover-community-mathlib4-bot