Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: basic results about preservation of kernels/cokernels #6279

Closed
wants to merge 5 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Aug 1, 2023

This PR shows basic results about the preservation of (limit) kernels forks by functors which preserve zero morphisms.


(Note: This is not completely straightforward because the 0 morphism is mapped to G.map 0, which is equal to 0, although not definitionally.)

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Aug 1, 2023
@joelriou joelriou changed the title feat: basic results about preservations of kernels/cokernels feat: basic results about preservation of kernels/cokernels Aug 1, 2023
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joelriou, have you seen the file CategoryTheory/Limits/Preserves/Shapes/Kernels.lean? I believe that there is some overlap between your results and the results in that file. I would suggest you move your results there and unify them with the existing ones.

@TwoFX TwoFX added the awaiting-author A reviewer has asked the author a question or requested changes label Aug 1, 2023
@joelriou
Copy link
Collaborator Author

joelriou commented Aug 1, 2023

Thanks @TwoFX ! I will try to make the two approaches converge...

@joelriou joelriou added the WIP Work in progress label Aug 1, 2023
@joelriou joelriou added awaiting-review The author would like community review of the PR and removed WIP Work in progress awaiting-author A reviewer has asked the author a question or requested changes labels Aug 1, 2023
@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 5, 2023
@joelriou joelriou added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 6, 2023
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 6, 2023
bors bot pushed a commit that referenced this pull request Aug 6, 2023
This PR shows basic results about the preservation of (limit) kernels forks by functors which preserve zero morphisms.
@bors
Copy link

bors bot commented Aug 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: basic results about preservation of kernels/cokernels [Merged by Bors] - feat: basic results about preservation of kernels/cokernels Aug 6, 2023
@bors bors bot closed this Aug 6, 2023
@bors bors bot deleted the preserve_kernel branch August 6, 2023 07:05
semorrison pushed a commit that referenced this pull request Aug 14, 2023
This PR shows basic results about the preservation of (limit) kernels forks by functors which preserve zero morphisms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants