[Merged by Bors] - chore: remove succ from Stirling #6280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PatrickMassot, I pushed a commit that replaces |
|
(Just a reminder that on the mathlib4 repo, if authors don't self-label with |
leanprover-community-mathlib4-bot
added
the
merge-conflict
PatrickMassot
added
the
awaiting-review
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
The Stirling formula file was full of `n.succ` whose only purpose was to steer automatic coercion to a real number. Then formulas became unreadable and had to be restated in docstrings, leading to the error flagged [on zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Typo.20in.20documentation.20of.20.60log_stirling_seq_formula.60/near/380554733) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
The Stirling formula file was full of `n.succ` whose only purpose was to steer automatic coercion to a real number. Then formulas became unreadable and had to be restated in docstrings, leading to the error flagged [on zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Typo.20in.20documentation.20of.20.60log_stirling_seq_formula.60/near/380554733) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
ebab
pushed a commit
that referenced
this pull request
Sep 11, 2023
The Stirling formula file was full of `n.succ` whose only purpose was to steer automatic coercion to a real number. Then formulas became unreadable and had to be restated in docstrings, leading to the error flagged [on zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Typo.20in.20documentation.20of.20.60log_stirling_seq_formula.60/near/380554733) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
The Stirling formula file was full of `n.succ` whose only purpose was to steer automatic coercion to a real number. Then formulas became unreadable and had to be restated in docstrings, leading to the error flagged [on zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Typo.20in.20documentation.20of.20.60log_stirling_seq_formula.60/near/380554733) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Stirling formula file was full of
n.succwhose only purpose was to steer automatic coercion to a real number. Then formulas became unreadable and had to be restated in docstrings, leading to the error flagged on zulip