Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Logic/Function/Basic): @[simp] lemmas #6303

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(Logic/Function/Basic): @[simp] lemmas #6303

wants to merge 1 commit into from

Conversation

semorrison
Copy link
Contributor

@semorrison semorrison commented Aug 2, 2023 •
edited

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Aug 2, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Aug 2, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@semorrison semorrison force-pushed the of_comp_iff_simp branch 2 times, most recently from a0a7aee to 66ee3b6 Compare August 3, 2023 03:40
@semorrison
Copy link
Contributor Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 66ee3b6.Found no runs to compare against.

@semorrison
Copy link
Contributor Author

!bench

@semorrison semorrison added the awaiting-author A reviewer has asked the author a question or requested changes label Aug 6, 2023
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit f6a97da.
There were no significant changes against commit 944ee07.

@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 6, 2023
@j-loreaux
Copy link
Collaborator

I looked at the benchmark and it seems (to me) to be mostly noise, so I think it's fine to merge this.

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 8, 2023
bors bot pushed a commit that referenced this pull request Aug 8, 2023
@semorrison
chore(Logic/Function/Basic): @[simp] lemmas (#6303)
e176cb0 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Aug 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Logic/Function/Basic): @[simp] lemmas [Merged by Bors] - chore(Logic/Function/Basic): @[simp] lemmas Aug 8, 2023
@bors bors bot closed this Aug 8, 2023
@bors bors bot deleted the of_comp_iff_simp branch August 8, 2023 23:08
semorrison added a commit that referenced this pull request Aug 14, 2023
@semorrison
chore(Logic/Function/Basic): @[simp] lemmas (#6303)
bc28dfd 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @leanprover-community-mathlib4-bot @leanprover-bot @j-loreaux