[Merged by Bors] - chore(Mathlib/LinearAlgebra/Basis): Move results about vector spaces to a new file #6321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a new file This breaks a dependency cycle with `Module.Free`, which means we can immediately show that all vector spaces are free modules. The lemmas are moved without modification in this PR. A subsequent PR can use the `Module.Free` results to golf the vector space ones, and deduplicate the API.
eric-wieser
added
awaiting-review
eric-wieser
commented
Aug 2, 2023
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
…to a new file (#6321) This breaks a dependency cycle with `Module.Free`, which means we can immediately show that all vector spaces are free modules. The lemmas are moved without modification in this PR. A subsequent PR can use the `Module.Free` results to golf the vector space ones, and deduplicate the API. Co-authored-by: Oliver Nash <github@olivernash.org>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
Aug 3, 2023
…to a new file (#6321) This breaks a dependency cycle with `Module.Free`, which means we can immediately show that all vector spaces are free modules. The lemmas are moved without modification in this PR. A subsequent PR can use the `Module.Free` results to golf the vector space ones, and deduplicate the API. Co-authored-by: Oliver Nash <github@olivernash.org>
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
…to a new file (#6321) This breaks a dependency cycle with `Module.Free`, which means we can immediately show that all vector spaces are free modules. The lemmas are moved without modification in this PR. A subsequent PR can use the `Module.Free` results to golf the vector space ones, and deduplicate the API. Co-authored-by: Oliver Nash <github@olivernash.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks a dependency cycle with
Module.Free, which means we can immediately show that all vector spaces are free modules.The lemmas are moved without modification in this PR. A subsequent PR can use the
Module.Freeresults to golf the vector space ones, and deduplicate the API.