[Merged by Bors] - chore: adjust priorities of mem_map lemmas #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
2 tasks
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
semorrison
added
the
awaiting-review
leanprover-community-mathlib4-bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
The `mem_map` lemmas were inconsistently either not `simp` lemmas at all, `simp` lemmas, or `simp` lemmas with a lowered priority. This PR makes them uniformly low priority simp lemmas, and adds a few simp attributes to "better" simp lemmas instead. (However these lemmas are themselves quite inconsistent across different algebraic structures, and I haven't attempted to add missing ones.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
added a commit
that referenced
this pull request
Aug 15, 2023
The `mem_map` lemmas were inconsistently either not `simp` lemmas at all, `simp` lemmas, or `simp` lemmas with a lowered priority. This PR makes them uniformly low priority simp lemmas, and adds a few simp attributes to "better" simp lemmas instead. (However these lemmas are themselves quite inconsistent across different algebraic structures, and I haven't attempted to add missing ones.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
semorrison
added a commit
that referenced
this pull request
Aug 15, 2023
The `mem_map` lemmas were inconsistently either not `simp` lemmas at all, `simp` lemmas, or `simp` lemmas with a lowered priority. This PR makes them uniformly low priority simp lemmas, and adds a few simp attributes to "better" simp lemmas instead. (However these lemmas are themselves quite inconsistent across different algebraic structures, and I haven't attempted to add missing ones.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
semorrison
added a commit
that referenced
this pull request
Aug 17, 2023
The `mem_map` lemmas were inconsistently either not `simp` lemmas at all, `simp` lemmas, or `simp` lemmas with a lowered priority. This PR makes them uniformly low priority simp lemmas, and adds a few simp attributes to "better" simp lemmas instead. (However these lemmas are themselves quite inconsistent across different algebraic structures, and I haven't attempted to add missing ones.) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mem_maplemmas were inconsistently either notsimplemmas at all,simplemmas, orsimplemmas with a lowered priority.This PR makes them uniformly low priority simp lemmas, and adds a few simp attributes to "better" simp lemmas instead. (However these lemmas are themselves quite inconsistent across different algebraic structures, and I haven't attempted to add missing ones.)