Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(data/{Finset,Multiset}): better line breaks in Repr #6333

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

See the attached tests

Previously this gave {[1, 2,\n 3], [4, 5, 6]}, where the line break would be within items rather than between items.


Open in Gitpod

See the attached tests

Previously this gave `{[1, 2,\n 3], [4, 5, 6]}`, where the line break
would be within items rather than between items.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands awaiting-CI labels Aug 3, 2023
@eric-wieser eric-wieser changed the title feat(data/{Finset,Multiset}): fix line breaks in Repr fix(data/{Finset,Multiset}): better line breaks in Repr Aug 3, 2023
Comment on lines +3 to +4
#eval show Lean.MetaM Unit from guard <|
(repr (0 : Multiset (List ℕ)) |>.pretty 15) = "0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests might be clearer with a simple #guard_msgs, rather than mentioning MetaM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specifically want to use a narrow width, so would prefer to test equality.

Is there a better way to write simple assertions than what I do here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a handful of other tests in this style, so I'm going to leave it as is for now

bors merge

@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Aug 3, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Aug 3, 2023
bors bot pushed a commit that referenced this pull request Aug 4, 2023
See the attached tests

Previously this gave `{[1, 2,\n 3], [4, 5, 6]}`, where the line break would be within items rather than between items.
@bors
Copy link

bors bot commented Aug 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix(data/{Finset,Multiset}): better line breaks in Repr [Merged by Bors] - fix(data/{Finset,Multiset}): better line breaks in Repr Aug 4, 2023
@bors bors bot closed this Aug 4, 2023
@bors bors bot deleted the eric-wieser/fix-multiset-repr branch August 4, 2023 12:03
semorrison pushed a commit that referenced this pull request Aug 14, 2023
See the attached tests

Previously this gave `{[1, 2,\n 3], [4, 5, 6]}`, where the line break would be within items rather than between items.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants