Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: delete Nat.shiftr and Nat.shiftl #6356
[Merged by Bors] - feat: delete Nat.shiftr and Nat.shiftl #6356
Changes from all commits
b8c1db6
af42dd2
c6f29aa
16cde41
a072dc6
54c1f0d
ea15870
a849f10
6ca7971
7c4bc98
c7484d4
16ce204
e0005a6
77d2ed4
1b4579a
490a0ed
73694a5
955a9a7
04e9677
4695dd5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mathlib linter is complaining that the LHS is not in simp normal formal. That's because
shiftLeft_eq
issimp
-ed inStd.Data.Nat.Lemmas
and it saysm <<< n = m*2^n
. I don't think that lemma should besimp
-ed. It's quite problematic since I keep having to remove it from thesimp
set when usingsimp
anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@digama0, what are your thoughts on this?