[Merged by Bors] - fix(NumberTheory/FermatPsp): Update definition and theorem names #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Just a reminder that on the mathlib4 repo, if authors don't self-label with |
osbourn
added
the
awaiting-review
semorrison
added
the
t-number-theory
kbuzzard
approved these changes
Aug 9, 2023
kbuzzard
added
awaiting-author
This helps remove two "rw" statements
osbourn
added
awaiting-review
|
Thanks! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by kbuzzard. |
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
Fix some definition and theorem names in NumberTheory/FermatPsp. Most of these definitions were previously under the `FermatPsp` namespace. This PR removes the `FermatPsp` namespace and places all the definitions under the `Nat` namespace. The following are the main changes made to names: - `FermatPsp.ProbablePrime` -> `Nat.ProbablePrime` - `FermatPsp` -> `Nat.FermatPsp` - `FermatPsp.coprime_of_probablePrime` -> `Nat.coprime_of_probablePrime` - `FermatPsp.probablePrime_iff_modEq` -> `Nat.probablePrime_iff_modEq` - `FermatPsp.coprime_of_fermatPsp` -> `Nat.coprime_of_fermatPsp` - `FermatPsp.base_one` -> `Nat.fermatPsp_base_one` - `FermatPsp.exists_infinite_pseudoprimes` -> `Nat.exists_infinite_pseudoprimes` - `FermatPsp.frequently_atTop_fermatPsp` -> `Nat.frequently_atTop_fermatPsp` - `FermatPsp.infinite_setOf_prime_modeq_one` -> `Nat.infinite_setOf_pseudoprimes` The last name was originally a mistake that came from the proof I used as reference. This PR additionally contains a few fixes for the proofs that were needed because they are now in the `Nat` namespace. It also removes the `Mathlib.Data.Nat.Prime` import because it is transitively included in the `Mathlib.FieldTheory.Finite.Basic` import.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
Fix some definition and theorem names in NumberTheory/FermatPsp. Most of these definitions were previously under the `FermatPsp` namespace. This PR removes the `FermatPsp` namespace and places all the definitions under the `Nat` namespace. The following are the main changes made to names: - `FermatPsp.ProbablePrime` -> `Nat.ProbablePrime` - `FermatPsp` -> `Nat.FermatPsp` - `FermatPsp.coprime_of_probablePrime` -> `Nat.coprime_of_probablePrime` - `FermatPsp.probablePrime_iff_modEq` -> `Nat.probablePrime_iff_modEq` - `FermatPsp.coprime_of_fermatPsp` -> `Nat.coprime_of_fermatPsp` - `FermatPsp.base_one` -> `Nat.fermatPsp_base_one` - `FermatPsp.exists_infinite_pseudoprimes` -> `Nat.exists_infinite_pseudoprimes` - `FermatPsp.frequently_atTop_fermatPsp` -> `Nat.frequently_atTop_fermatPsp` - `FermatPsp.infinite_setOf_prime_modeq_one` -> `Nat.infinite_setOf_pseudoprimes` The last name was originally a mistake that came from the proof I used as reference. This PR additionally contains a few fixes for the proofs that were needed because they are now in the `Nat` namespace. It also removes the `Mathlib.Data.Nat.Prime` import because it is transitively included in the `Mathlib.FieldTheory.Finite.Basic` import.
semorrison
pushed a commit
that referenced
this pull request
Aug 15, 2023
Fix some definition and theorem names in NumberTheory/FermatPsp. Most of these definitions were previously under the `FermatPsp` namespace. This PR removes the `FermatPsp` namespace and places all the definitions under the `Nat` namespace. The following are the main changes made to names: - `FermatPsp.ProbablePrime` -> `Nat.ProbablePrime` - `FermatPsp` -> `Nat.FermatPsp` - `FermatPsp.coprime_of_probablePrime` -> `Nat.coprime_of_probablePrime` - `FermatPsp.probablePrime_iff_modEq` -> `Nat.probablePrime_iff_modEq` - `FermatPsp.coprime_of_fermatPsp` -> `Nat.coprime_of_fermatPsp` - `FermatPsp.base_one` -> `Nat.fermatPsp_base_one` - `FermatPsp.exists_infinite_pseudoprimes` -> `Nat.exists_infinite_pseudoprimes` - `FermatPsp.frequently_atTop_fermatPsp` -> `Nat.frequently_atTop_fermatPsp` - `FermatPsp.infinite_setOf_prime_modeq_one` -> `Nat.infinite_setOf_pseudoprimes` The last name was originally a mistake that came from the proof I used as reference. This PR additionally contains a few fixes for the proofs that were needed because they are now in the `Nat` namespace. It also removes the `Mathlib.Data.Nat.Prime` import because it is transitively included in the `Mathlib.FieldTheory.Finite.Basic` import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some definition and theorem names in NumberTheory/FermatPsp. Most of these definitions were previously under the
FermatPspnamespace. This PR removes theFermatPspnamespace and places all the definitions under theNatnamespace.The following are the main changes made to names:
FermatPsp.ProbablePrime->Nat.ProbablePrimeFermatPsp->Nat.FermatPspFermatPsp.coprime_of_probablePrime->Nat.coprime_of_probablePrimeFermatPsp.probablePrime_iff_modEq->Nat.probablePrime_iff_modEqFermatPsp.coprime_of_fermatPsp->Nat.coprime_of_fermatPspFermatPsp.base_one->Nat.fermatPsp_base_oneFermatPsp.exists_infinite_pseudoprimes->Nat.exists_infinite_pseudoprimesFermatPsp.frequently_atTop_fermatPsp->Nat.frequently_atTop_fermatPspFermatPsp.infinite_setOf_prime_modeq_one->Nat.infinite_setOf_pseudoprimesThe last name was originally a mistake that came from the proof I used as reference.
This PR additionally contains a few fixes for the proofs that were needed because they are now in the
Natnamespace. It also removes theMathlib.Data.Nat.Primeimport because it is transitively included in theMathlib.FieldTheory.Finite.Basicimport.I made the
FermatPspfile when I was newer to Lean, and I think the new names are a bit closer to the rest of the naming convention in Mathlib. I am still new to the Lean 4 naming conventions so please let me know if I made any mistakes.In the future, I might make the definition of
Nat.ProbablePrimerely on modular arithmetic rather than divisibility.