Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: more basic API for pretriangulated categories #6377

Closed
wants to merge 4 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Aug 5, 2023

This PR slightly extends the basic API of pretriangulated categories.


Open in Gitpod

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 coyoneda_exact lemmas, but only 2 yoneda_exact lemmas. Is that on purpose?

@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Aug 5, 2023
@joelriou
Copy link
Collaborator Author

joelriou commented Aug 5, 2023

There are 3 coyoneda_exact lemmas, but only 2 yoneda_exact lemmas. Is that on purpose?

Yes, it is on purpose. Indeed, the yoneda_exact₁ variant would be quite unpractical because of the complicated formulation of the condition on the morphism:

lemma yoneda_exact₁ (T : Triangle C) (hT : T ∈ distTriang C) {X : C} (f : T.obj₁ ⟶ X)
    (hf : T.mor₃⟦(-1 : ℤ)⟧' ≫ (shiftEquiv C (1 : ℤ)).unitIso.inv.app T.obj₁ ≫ f = 0) :
    ∃ (g : T.obj₂ ⟶ X), f = T.mor₁ ≫ g :=
  yoneda_exact₂ T.invRotate (inv_rot_of_dist_triangle _ hT) f (by
    simpa using hf)

If we ever need this in the applications, it would be more obvious to me to directly use yoneda_exact₂ T.invRotate rather than yoneda_exact₁. Do you think I should include it anyway?

@joelriou joelriou added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 5, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. I think your reasoning for leaving out the yoneda_exact_1 variant is fine.

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 9, 2023
bors bot pushed a commit that referenced this pull request Aug 9, 2023
This PR slightly extends the basic API of pretriangulated categories.
@bors
Copy link

bors bot commented Aug 9, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: more basic API for pretriangulated categories [Merged by Bors] - feat: more basic API for pretriangulated categories Aug 9, 2023
@bors bors bot closed this Aug 9, 2023
@bors bors bot deleted the pretriangulated_misc branch August 9, 2023 08:46
semorrison pushed a commit that referenced this pull request Aug 14, 2023
This PR slightly extends the basic API of pretriangulated categories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants