-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: more basic API for pretriangulated categories #6377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 3 coyoneda_exact
lemmas, but only 2 yoneda_exact
lemmas. Is that on purpose?
Yes, it is on purpose. Indeed, the lemma yoneda_exact₁ (T : Triangle C) (hT : T ∈ distTriang C) {X : C} (f : T.obj₁ ⟶ X)
(hf : T.mor₃⟦(-1 : ℤ)⟧' ≫ (shiftEquiv C (1 : ℤ)).unitIso.inv.app T.obj₁ ≫ f = 0) :
∃ (g : T.obj₂ ⟶ X), f = T.mor₁ ≫ g :=
yoneda_exact₂ T.invRotate (inv_rot_of_dist_triangle _ hT) f (by
simpa using hf) If we ever need this in the applications, it would be more obvious to me to directly use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response. I think your reasoning for leaving out the yoneda_exact_1
variant is fine.
bors merge
This PR slightly extends the basic API of pretriangulated categories.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This PR slightly extends the basic API of pretriangulated categories.
This PR slightly extends the basic API of pretriangulated categories.