Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Computability/CFG): define context-free grammars #6385

Closed
wants to merge 54 commits into from
Closed

[Merged by Bors] - feat(Computability/CFG): define context-free grammars #6385

wants to merge 54 commits into from

Conversation

madvorak
Copy link
Collaborator

@madvorak madvorak commented Aug 5, 2023

Open in Gitpod

@madvorak madvorak added the awaiting-review The author would like community review of the PR label Aug 5, 2023
@madvorak madvorak requested a review from ericrbg August 6, 2023 20:20
@madvorak madvorak removed the awaiting-review The author would like community review of the PR label Aug 7, 2023
@madvorak madvorak requested a review from alexjbest August 7, 2023 14:39
@madvorak madvorak added the awaiting-review The author would like community review of the PR label Aug 8, 2023
ericrbg
ericrbg reviewed Aug 12, 2023
View reviewed changes
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good generally!

Mathlib/Computability/CFG.lean Outdated Show resolved Hide resolved
Mathlib/Computability/CFG.lean Outdated Show resolved Hide resolved
Mathlib/Computability/CFG.lean Outdated Show resolved Hide resolved
Mathlib/Computability/CFG.lean Outdated Show resolved Hide resolved
@madvorak @ericrbg
Update Mathlib/Computability/CFG.lean
ff49913 
Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
@madvorak madvorak requested a review from ericrbg August 13, 2023 15:45
ericrbg
ericrbg approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Mathlib/Computability/CFG.lean Outdated Show resolved Hide resolved
@madvorak madvorak added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 12, 2023
@madvorak madvorak added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 13, 2023
eric-wieser
eric-wieser approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

Mathlib/Computability/ContextFreeGrammar.lean Outdated Show resolved Hide resolved
Mathlib/Computability/ContextFreeGrammar.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 13, 2023

✌️ madvorak can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 13, 2023
@madvorak
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 13, 2023
@madvorak @eric-wieser @alexjbest
feat(Computability/CFG): define context-free grammars (#6385)
faa8dc9 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
eric-wieser
eric-wieser reviewed Oct 13, 2023
View reviewed changes
Mathlib/Computability/Language.lean
deriving
DecidableEq, Repr, Fintype

attribute [nolint docBlame] Symbol.proxyType Symbol.proxyTypeEquiv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmill: should the derive handled automatically document these?

@bors
Copy link

bors bot commented Oct 13, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Computability/CFG): define context-free grammars [Merged by Bors] - feat(Computability/CFG): define context-free grammars Oct 13, 2023
@bors bors bot closed this Oct 13, 2023
@bors bors bot deleted the cfg branch October 13, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@ericrbg ericrbg ericrbg approved these changes

@JLimperg JLimperg JLimperg approved these changes

@alexjbest alexjbest Awaiting requested review from alexjbest

@arthurpaulino arthurpaulino Awaiting requested review from arthurpaulino

Assignees
No one assigned
Labels
delegated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@madvorak @eric-wieser @JLimperg @alexjbest @ericrbg @leanprover-community-mathlib4-bot