Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Units -- to_additive no longer complains #6400

Closed
wants to merge 1 commit into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Aug 6, 2023

Remove a porting note, since the reported to_additive issue seems resolved.

Algebra.Group.Units

Open in Gitpod

@adomani adomani added awaiting-review The author would like community review of the PR awaiting-CI labels Aug 6, 2023
@alexjbest
Copy link
Member

maintainer merge

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🚀 Pull request has been placed on the maintainer queue by alexjbest.

Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 7, 2023
bors bot pushed a commit that referenced this pull request Aug 7, 2023
Remove a porting note, since the reported `to_additive` issue seems resolved.

```
Algebra.Group.Units
```
@bors
Copy link

bors bot commented Aug 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: Units -- to_additive no longer complains [Merged by Bors] - chore: Units -- to_additive no longer complains Aug 7, 2023
@bors bors bot closed this Aug 7, 2023
@bors bors bot deleted the adomani_oneToAdditivePortingNote branch August 7, 2023 16:43
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Remove a porting note, since the reported `to_additive` issue seems resolved.

```
Algebra.Group.Units
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants