Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: bump leantar version #6430

Closed
wants to merge 1 commit into from
Closed

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Aug 7, 2023

This fixes the issue that leantar-0.1.4.exe was not actually statically linked on windows, reported by @MohanadAhmed . Could someone using MacOS aarch64 check that this still works? All other OSs should be unaffected.


Open in Gitpod

@digama0
Copy link
Member Author

digama0 commented Aug 7, 2023

Reports from macos aarch64 users seem to be good, so I think this PR is ready to merge.

@digama0 digama0 added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Aug 7, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 8, 2023
bors bot pushed a commit that referenced this pull request Aug 8, 2023
This fixes the issue that leantar-0.1.4.exe was not actually statically linked on windows, reported by @MohanadAhmed . Could someone using MacOS aarch64 check that this still works? All other OSs should be unaffected.
@bors
Copy link

bors bot commented Aug 8, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 8, 2023
This fixes the issue that leantar-0.1.4.exe was not actually statically linked on windows, reported by @MohanadAhmed . Could someone using MacOS aarch64 check that this still works? All other OSs should be unaffected.
@bors
Copy link

bors bot commented Aug 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: bump leantar version [Merged by Bors] - chore: bump leantar version Aug 8, 2023
@bors bors bot closed this Aug 8, 2023
@bors bors bot deleted the leantar_0_1_5 branch August 8, 2023 03:06
semorrison pushed a commit that referenced this pull request Aug 14, 2023
This fixes the issue that leantar-0.1.4.exe was not actually statically linked on windows, reported by @MohanadAhmed . Could someone using MacOS aarch64 check that this still works? All other OSs should be unaffected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants