Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: MeasureTheory.Integral.Bochner: integral_fintype and similar #6446

Closed
wants to merge 11 commits into from

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Aug 8, 2023

This adds some lemmas about integral where we already have the corresponding
lemmas for lintegral. The goal is integral_fintype, which rewrites an
integral over a finite type as a finite sum over the elements, with singleton
measures (these singleton measures can then further be simplified when the
measure comes from a Pmf, but that will follow some other time.).

Also fixes lemma name integral_eq_lintegral_pos_part_sub_lintegral_neg_part in
the module comments.


Open in Gitpod

@nomeata nomeata marked this pull request as ready for review August 8, 2023 14:06
@nomeata nomeata added awaiting-review t-measure-probability Measure theory / Probability theory labels Aug 8, 2023
@nomeata
Copy link
Collaborator Author

nomeata commented Aug 8, 2023

The motivation of the present PR is to be able to do #6454

@nomeata
Copy link
Collaborator Author

nomeata commented Aug 9, 2023

I’ll be traveling without a laptop for week, and will address review comments afterwards. Should anyone want to adopt this PR and see it through, that’s fine with me as well.

Copy link
Contributor

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I left a few comments about code style. I'll come back to this for a full review later.

Mathlib/MeasureTheory/Integral/Bochner.lean Outdated Show resolved Hide resolved
Mathlib/MeasureTheory/Integral/Bochner.lean Outdated Show resolved Hide resolved
Mathlib/MeasureTheory/Integral/Bochner.lean Outdated Show resolved Hide resolved
Mathlib/MeasureTheory/Integral/Bochner.lean Outdated Show resolved Hide resolved
Mathlib/MeasureTheory/Integral/Bochner.lean Outdated Show resolved Hide resolved
Mathlib/MeasureTheory/Integral/Bochner.lean Outdated Show resolved Hide resolved
Mathlib/MeasureTheory/Integral/Bochner.lean Outdated Show resolved Hide resolved
nomeata and others added 4 commits August 10, 2023 11:12
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@nomeata
Copy link
Collaborator Author

nomeata commented Aug 24, 2023

@RemyDegenne, what is your preferred etiquette: Should I re-request a review from you after addressing your initial one?

@RemyDegenne
Copy link
Contributor

Usually I would simply have seen that you had pushed modifications to the branch and I would have come back to this PR without you needing to ping me, but I was on vacation recently and I lost track of those reviews. Sorry about the long delay. I'll review it shortly.

Copy link
Contributor

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!
bors r+

Mathlib/MeasureTheory/Integral/Bochner.lean Outdated Show resolved Hide resolved
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Aug 24, 2023
@RemyDegenne
Copy link
Contributor

Sorry, typo:
bors r-
bors d+

@bors
Copy link

bors bot commented Aug 24, 2023

✌️ nomeata can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented Aug 24, 2023

Canceled.

Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@nomeata
Copy link
Collaborator Author

nomeata commented Aug 24, 2023

bors r+

bors bot pushed a commit that referenced this pull request Aug 24, 2023
…6446)

This adds some lemmas about `integral` where we already have the corresponding
lemmas for `lintegral`. The goal is `integral_fintype`, which rewrites an
integral over a finite type as a finite sum over the elements, with singleton
measures (these singleton measures can then further be simplified when the
measure comes from a `Pmf`, but that will follow some other time.).

Also fixes lemma name `integral_eq_lintegral_pos_part_sub_lintegral_neg_part` in
the module comments.
@bors
Copy link

bors bot commented Aug 24, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: MeasureTheory.Integral.Bochner: integral_fintype and similar [Merged by Bors] - feat: MeasureTheory.Integral.Bochner: integral_fintype and similar Aug 24, 2023
@bors bors bot closed this Aug 24, 2023
@bors bors bot deleted the joachim/integral_fintype branch August 24, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants