-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port Order.GameAdd #645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I like autoimplicits here, because α
and β
are almost always just arbitrary types.
Mathlib/Order/GameAdd.lean
Outdated
-/ | ||
|
||
|
||
variable {α β : Type _} (rα : α → α → Prop) (rβ : β → β → Prop) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable {α β : Type _} (rα : α → α → Prop) (rβ : β → β → Prop) | |
variable (rα : α → α → Prop) (rβ : β → β → Prop) |
see https://github.com/leanprover-community/mathlib4/wiki#auto-implicits
Mathlib/Order/GameAdd.lean
Outdated
/-- If `a` is accessible under `rα` and `b` is accessible under `rβ`, then `(a, b)` is | ||
accessible under `Prod.GameAdd rα rβ`. Notice that `Prod.lexAccessible` requires the | ||
stronger condition `∀ b, Acc rβ b`. -/ | ||
theorem Acc.prod_gameAdd {a b} (ha : Acc rα a) (hb : Acc rβ b) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theorem Acc.prod_gameAdd {a b} (ha : Acc rα a) (hb : Acc rβ b) : | |
theorem Acc.prod_gameAdd (ha : Acc rα a) (hb : Acc rβ b) : |
I don't understand why these variables are mentioned
After making the changes, Moritz suggested, bors d+ |
✌️ dwarn can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
mathlib SHA: fd47bdf09e90f553519c712378e651975fe8c829
Pull request successfully merged into master. Build succeeded:
|
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * leanprover-community/mathlib4#563 * leanprover-community/mathlib4#608 * leanprover-community/mathlib4#627 * leanprover-community/mathlib4#638 * leanprover-community/mathlib4#641 * leanprover-community/mathlib4#645 * leanprover-community/mathlib4#650
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * leanprover-community/mathlib4#563 * leanprover-community/mathlib4#608 * leanprover-community/mathlib4#627 * leanprover-community/mathlib4#638 * leanprover-community/mathlib4#641 * leanprover-community/mathlib4#645 * leanprover-community/mathlib4#650
mathlib SHA: fd47bdf09e90f553519c712378e651975fe8c829