Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: matrix equality of strongly regular graphs #6507

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: matrix equality of strongly regular graphs #6507

wants to merge 13 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

@Parcly-Taxel Parcly-Taxel commented Aug 10, 2023 •
edited

Open in Gitpod

@Parcly-Taxel Parcly-Taxel added new-feature Add features not present in Mathlib 3 t-combinatorics Combinatorics awaiting-review The author would like community review of the PR labels Aug 10, 2023
eric-wieser
eric-wieser approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'll let a graph theorist give the final review

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

ocfnash
ocfnash approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the two suggestions and then feel free to merge.

bors d+

Mathlib/Combinatorics/SimpleGraph/Connectivity.lean Outdated Show resolved Hide resolved
Mathlib/Combinatorics/SimpleGraph/StronglyRegular.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Aug 20, 2023

✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Aug 20, 2023
@Parcly-Taxel
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 20, 2023
@Parcly-Taxel
feat: matrix equality of strongly regular graphs (#6507)
dcc92db
@bors
Copy link

bors bot commented Aug 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: matrix equality of strongly regular graphs [Merged by Bors] - feat: matrix equality of strongly regular graphs Aug 20, 2023
@bors bors bot closed this Aug 20, 2023
@bors bors bot deleted the srg_matrix_eq branch August 20, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@ocfnash ocfnash ocfnash approved these changes

@kmill kmill Awaiting requested review from kmill

Assignees
No one assigned
Labels
delegated new-feature Add features not present in Mathlib 3 t-combinatorics Combinatorics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Parcly-Taxel @eric-wieser @ocfnash @leanprover-community-mathlib4-bot