[Merged by Bors] - feat: charP_iff_prime_eq_zero #6516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChrisHughes24
commented
Aug 11, 2023
ChrisHughes24
commented
ChrisHughes24
added
the
awaiting-review
ChrisHughes24
changed the title
eric-wieser
reviewed
Aug 11, 2023
eric-wieser
changed the title
eric-wieser
reviewed
Aug 11, 2023
| @@ -605,7 +605,12 @@ theorem ringChar_of_prime_eq_zero [Nontrivial R] {p : ℕ} (hprime : Nat.Prime p | |||
| Or.resolve_left ((Nat.dvd_prime hprime).1 (ringChar.dvd hp0)) ringChar_ne_one | |||
| #align char_p.ring_char_of_prime_eq_zero CharP.ringChar_of_prime_eq_zero | |||
|
|
|||
| end CharOne | |||
| theorem charP_iff_prime_eq_zero [Nontrivial R] {p : ℕ} (hp : p.Prime) : | |||
There was a problem hiding this comment.
I'd be tempted to add a cast to this name to match cast_eq_zero, though you should do the same to the ringChar lemma above (and the PR title) if you agree:
Suggested change
| theorem charP_iff_prime_eq_zero [Nontrivial R] {p : ℕ} (hp : p.Prime) : | |
| theorem charP_iff_cast_eq_zero_of_prime [Nontrivial R] {p : ℕ} (hp : p.Prime) : |
bors d+
|
✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
semorrison
pushed a commit
that referenced
this pull request
Aug 15, 2023
semorrison
pushed a commit
that referenced
this pull request
Aug 15, 2023
semorrison
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.