[Merged by Bors] - fix(LinearAlgebra/Dimension): make LinearMap.rank an abbrev #6545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a statement like:
```
example : rank K V = L.rank + rank K (ker L) := by
sorry
```
required rewriting `LinearMap.rank` before manually finding
the existence of `rank_range_add_rank_ker`.
After this change though, `exact?` successfully finds the lemma / solves
the above.
Julian
added
the
awaiting-review
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
Previously, a statement like:
```lean
import Mathlib.LinearAlgebra.Dimension
import Mathlib.Tactic
variable {K : Type} [Field K]
variable {V W : Type} [AddCommGroup V] [AddCommGroup W] [Module K V] [Module K W]
variable {L : V →ₗ[K] W}
open LinearMap (ker)
open Module (rank)
example : rank K V = L.rank + rank K (ker L) := by
sorry
```
required rewriting `LinearMap.rank` before manually finding the existence of `rank_range_add_rank_ker`.
After this change though, `exact?` successfully finds the lemma / solves the above.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a statement like:
required rewriting
LinearMap.rankbefore manually finding the existence ofrank_range_add_rank_ker.After this change though,
exact?successfully finds the lemma / solves the above.