-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Data/Rel): prove simple propositions about images, preimages and graphs of relations #6559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, and sorry for the delay in reviewing it.
simp attributes Co-authored-by: Johan Commelin <johan@commelin.net>
Changes should be resolved, I wasn't too sure when to add lemmas of this kind to the default simps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long wait! It seems we have a bug somewhere because Github claims this PR was last updated a couple days ago. I have quite a few remarks but don't worry, they are mostly pedantic. Overall this is already very nice work!
bors d+
rw[←hf.left] | ||
simp only [forall_eq', and_self] | ||
· intro h | ||
rcases Classical.axiomOfChoice (λ x ↦ (h x).exists) with ⟨f,hf⟩ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should probably be an equivalent to the axiom of choice for ExistsUnique
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh if only there was, ExistsUnique seems a little underdeveloped when it comes to these things
✌️ uniwuni can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
bors r+ |
… graphs of relations (#6559) Add lemmas about relation composition with top and bottom elements, conditions under which images under a relation form the whole codomain, and the equivalence between being a functional relation and representable by the graph of a function. Co-authored-by: uniwuni <95649083+uniwuni@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Add lemmas about relation composition with top and bottom elements, conditions under which images under a relation form the whole codomain, and the equivalence between being a functional relation and representable by the graph of a function.