Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/Rel): prove simple propositions about images, preimages and graphs of relations #6559

Closed
wants to merge 6 commits into from

Conversation

uniwuni
Copy link
Collaborator

@uniwuni uniwuni commented Aug 13, 2023

Add lemmas about relation composition with top and bottom elements, conditions under which images under a relation form the whole codomain, and the equivalence between being a functional relation and representable by the graph of a function.


Open in Gitpod

@uniwuni uniwuni added the awaiting-review The author would like community review of the PR label Aug 13, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, and sorry for the delay in reviewing it.

Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rel.lean Show resolved Hide resolved
Mathlib/Data/Rel.lean Show resolved Hide resolved
Mathlib/Data/Rel.lean Show resolved Hide resolved
Mathlib/Data/Rel.lean Show resolved Hide resolved
Mathlib/Data/Rel.lean Show resolved Hide resolved
Mathlib/Data/Rel.lean Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 8, 2023
simp attributes

Co-authored-by: Johan Commelin <johan@commelin.net>
@uniwuni
Copy link
Collaborator Author

uniwuni commented Sep 9, 2023

Changes should be resolved, I wasn't too sure when to add lemmas of this kind to the default simps

@uniwuni uniwuni added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 10, 2023
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:26
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:13
@Vierkantor Vierkantor self-assigned this Nov 2, 2023
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait! It seems we have a bug somewhere because Github claims this PR was last updated a couple days ago. I have quite a few remarks but don't worry, they are mostly pedantic. Overall this is already very nice work!

bors d+

Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
rw[←hf.left]
simp only [forall_eq', and_self]
· intro h
rcases Classical.axiomOfChoice (λ x ↦ (h x).exists) with ⟨f,hf⟩
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should probably be an equivalent to the axiom of choice for ExistsUnique.

Copy link
Collaborator Author

@uniwuni uniwuni Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh if only there was, ExistsUnique seems a little underdeveloped when it comes to these things

Mathlib/Data/Rel.lean Outdated Show resolved Hide resolved
Copy link

bors bot commented Nov 2, 2023

✌️ uniwuni can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Nov 2, 2023
uniwuni and others added 2 commits November 2, 2023 12:54
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@uniwuni
Copy link
Collaborator Author

uniwuni commented Nov 2, 2023

bors r+

bors bot pushed a commit that referenced this pull request Nov 2, 2023
… graphs of relations (#6559)

Add lemmas about relation composition with top and bottom elements, conditions under which images under a relation form the whole codomain, and the equivalence between being a functional relation and representable by the graph of a function.



Co-authored-by: uniwuni <95649083+uniwuni@users.noreply.github.com>
Copy link

bors bot commented Nov 2, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Data/Rel): prove simple propositions about images, preimages and graphs of relations [Merged by Bors] - feat(Data/Rel): prove simple propositions about images, preimages and graphs of relations Nov 2, 2023
@bors bors bot closed this Nov 2, 2023
@bors bors bot deleted the uniwuni_relation_identities branch November 2, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants