Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(LinearPMap): Closure and inverse commute #6563

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(LinearPMap): Closure and inverse commute #6563

wants to merge 4 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Aug 13, 2023

Open in Gitpod

@mcdoll mcdoll added awaiting-review The author would like community review of the PR awaiting-CI t-topology Topological spaces, uniform spaces, metric spaces, filters t-analysis Analysis (normed *, calculus) labels Aug 13, 2023
dupuisf
dupuisf reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor quibble regarding variable placement, but otherwise LGTM!

bors d+

Mathlib/Topology/Algebra/Module/LinearPMap.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Aug 17, 2023

✌️ mcdoll can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Aug 17, 2023
@mcdoll
Copy link
Member Author

mcdoll commented Aug 18, 2023

bors merge

bors bot pushed a commit that referenced this pull request Aug 18, 2023
@mcdoll
feat(LinearPMap): Closure and inverse commute (#6563)
a331fc6
@bors
Copy link

bors bot commented Aug 18, 2023

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

bors bot pushed a commit that referenced this pull request Aug 18, 2023
@mcdoll
feat(LinearPMap): Closure and inverse commute (#6563)
891ac0b
@bors
Copy link

bors bot commented Aug 18, 2023

Build failed:

@mcdoll
Copy link
Member Author

mcdoll commented Aug 18, 2023

bors merge

bors bot pushed a commit that referenced this pull request Aug 18, 2023
@mcdoll
feat(LinearPMap): Closure and inverse commute (#6563)
9692874
@bors
Copy link

bors bot commented Aug 18, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(LinearPMap): Closure and inverse commute [Merged by Bors] - feat(LinearPMap): Closure and inverse commute Aug 18, 2023
@bors bors bot closed this Aug 18, 2023
@bors bors bot deleted the mcdoll/inverse_closure branch August 18, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated t-analysis Analysis (normed *, calculus) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcdoll @dupuisf @leanprover-community-mathlib4-bot