Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: compact subsets in products as cofiltered limits of projections #6578

Closed
wants to merge 16 commits into from

Conversation

dagurtomas
Copy link
Collaborator

@dagurtomas dagurtomas commented Aug 14, 2023

We exhibit a compact subset in a product of totally disconnected Hausdorff spaces as a limit of its projections to finite subsets of the indexing set, in the category Profinite. The proof is structured in the same way as Profinite.isIso_asLimitCone_lift and DiscreteQuotient.exists_of_compat.


Open in Gitpod

@dagurtomas dagurtomas added the WIP Work in progress label Aug 14, 2023
@dagurtomas dagurtomas changed the title feat: compact subsets in products as cofiltered limits of finite sets feat: compact subsets in products as cofiltered limits of projections Aug 14, 2023
@dagurtomas
Copy link
Collaborator Author

I'm not sure where to put the stuff that is currently in section General in Mathlib/Topology/Category/Profinite/Product. And maybe the rest belongs in Mathlib/Topology/Category/Profinite/AsLimit?

@dagurtomas
Copy link
Collaborator Author

Also, if there is a better way to implement ProjRestrict/ProjRestricts, those suggestions are very welcome!

@dagurtomas dagurtomas added the help-wanted The author needs attention to resolve issues label Aug 14, 2023
@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR awaiting-CI and removed WIP Work in progress labels Aug 20, 2023
@dagurtomas dagurtomas added WIP Work in progress and removed help-wanted The author needs attention to resolve issues awaiting-review The author would like community review of the PR labels Aug 21, 2023
@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR awaiting-CI and removed WIP Work in progress labels Aug 21, 2023
@dagurtomas dagurtomas added t-topology Topological spaces, uniform spaces, metric spaces, filters t-category-theory Category theory labels Aug 22, 2023
@joelriou
Copy link
Collaborator

joelriou commented Sep 9, 2023

About ProjRestrict, etc, would not it be better to redesign it (and also Proj and Set.proj) so that if we have φ : ι' → ι then there is an induced "pullback" map (∀ i, π i) → (∀ i', π (φ i)). Then, Set.proj is the direct image of a subset C by this map. (If it is not absolutely necessary, I am a little disturbed by the Inhabited instances which may seem to be a little bit artificial. If such assumptions is needed, Nonempty, which is a Prop, would presumably be better.)

@ADedecker
Copy link
Member

I agree with Joël (I meant to comment on that a while ago but then forgot about it, I'm very sorry). Incidentally I need similar results, so #6836 is proving continuity for these "precomposition" maps (although they are not literally precompositions because of dependent types). You could also use Set.restrict for the particular case of inclusion of a set into a type, but it's probably easier to work in greater generality than with subsets!
Then, if you really need to extend by dummy values, you can probably prove a continuity result for Function.extend. Does that make sense?

@dagurtomas
Copy link
Collaborator Author

If this gets merged, then Nöbeling (#6286) is ready for review

@joelriou
Copy link
Collaborator

joelriou commented Oct 3, 2023

The definitions/statements in this PR looks good to me, but they do not seem to be in appropriate namespaces. The results about profinite sets should be in the Profinite namespace. I think that FinsetFunctor and precomp should be renamed and/or put in a namespace in a way which reflects the fact that this is topology; also it seems that SetFunctor would be better than FinsetFunctor.

@dagurtomas
Copy link
Collaborator Author

I moved precomp to Topology/ContinuousFunction/Basic, and put everything else in the Profinite namespace. I changed both the FinsetFunctor namespace and the name of the functor FinsetsToProfinite to Profinite.IndexFunctor, where index refers to the indexing set of the product. Does this make sense?

Mathlib/Topology/Category/Profinite/Product.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Category/Profinite/Product.lean Outdated Show resolved Hide resolved
@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 6, 2023
@dagurtomas dagurtomas added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 6, 2023
@dagurtomas
Copy link
Collaborator Author

Build fails because of "no space left on device"...

@ADedecker
Copy link
Member

That happens from time to time, we've removed the affected runner for now until someone can fix the issue. I restarted the build.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 10, 2023
bors bot pushed a commit that referenced this pull request Oct 10, 2023
…#6578)

We exhibit a compact subset in a product of totally disconnected Hausdorff spaces as a limit of its projections to finite subsets of the indexing set, in the category `Profinite`. The proof is structured in the same way as `Profinite.isIso_asLimitCone_lift` and `DiscreteQuotient.exists_of_compat`.
@bors
Copy link

bors bot commented Oct 10, 2023

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Oct 10, 2023
…#6578)

We exhibit a compact subset in a product of totally disconnected Hausdorff spaces as a limit of its projections to finite subsets of the indexing set, in the category `Profinite`. The proof is structured in the same way as `Profinite.isIso_asLimitCone_lift` and `DiscreteQuotient.exists_of_compat`.
@bors
Copy link

bors bot commented Oct 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: compact subsets in products as cofiltered limits of projections [Merged by Bors] - feat: compact subsets in products as cofiltered limits of projections Oct 10, 2023
@bors bors bot closed this Oct 10, 2023
@bors bors bot deleted the dagur_ProfiniteProduct branch October 10, 2023 21:36
bors bot pushed a commit that referenced this pull request Nov 1, 2023
Nobeling's theorem: the Z-module of locally constant maps from a profinite set to the integers is free.

-  [x] depends on: #6360 
-  [x] depends on: #6373 
-  [x] depends on: #6395 
-  [x] depends on: #6396  
-  [x] depends on: #6432
-  [x] depends on: #6520
-  [x] depends on: #6578
-  [x] depends on: #6589 
-  [x] depends on: #6722 
-  [x] depends on: #7829 
-  [x] depends on: #7895 
-  [x] depends on: #7896 
-  [x] depends on: #7897  
-  [x] depends on: #7899
fgdorais pushed a commit that referenced this pull request Nov 1, 2023
Nobeling's theorem: the Z-module of locally constant maps from a profinite set to the integers is free.

-  [x] depends on: #6360 
-  [x] depends on: #6373 
-  [x] depends on: #6395 
-  [x] depends on: #6396  
-  [x] depends on: #6432
-  [x] depends on: #6520
-  [x] depends on: #6578
-  [x] depends on: #6589 
-  [x] depends on: #6722 
-  [x] depends on: #7829 
-  [x] depends on: #7895 
-  [x] depends on: #7896 
-  [x] depends on: #7897  
-  [x] depends on: #7899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants