[Merged by Bors] - feat: port Algebra.Hom.Group #659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with module, class, and some lemma docstrings I kept the additional later-file defns near the bottom Turns out this file doesn't rely on the Logic.Nontrivial import
…efs' into winstonyin
This reverts commit 698f6ec.
…to pechersky/port-group-with-zero-defs
|
That's fixed, but now blocked by leanprover/lean4#1907. |
1 task
|
I think I've now killed off all the porting notes (baring one about to_additive). This PR uses a forked version of Lean 4 until nightly-2022-12-03 is available. It will be broken until aesop gets updated in leanprover-community/aesop#32. (Edit: aesop updated.) |
2 tasks
semorrison
added
the
merge-conflict
|
bors merge |
|
👎 Rejected by label |
github-actions
bot
added
ready-to-merge
semorrison
removed
merge-conflict
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
mathlib3 SHA: 8c53048add6ffacdda0b36c4917bfe37e209b0ba - [x] depends on #563 - [x] depends on leanprover-community/mathlib#17733 - [x] depends on leanprover/lean4#1901 - [x] depends on leanprover/lean4#1907 Co-authored-by: Winston Yin <winstonyin@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2022
mathlib3 SHA: 76171581280d5b5d1e2d1f4f37e5420357bdc636 Seems relatively straightforward. Some lemma names (e.g. `units.coe_zpow -> Units.val_zpow_eq_zpow_val`) are renamed to refer to `val` instead of `coe`, following the convention used in `Algebra.Group.Units`. - [x] depends on: #659 Co-authored-by: Winston Yin <winstonyin@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
This was referenced Dec 4, 2022
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Dec 6, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.divisibility.basic`: leanprover-community/mathlib4#833 * `algebra.group.with_one.defs`: leanprover-community/mathlib4#841 * `algebra.hom.commute`: leanprover-community/mathlib4#831 * `algebra.hom.group`: leanprover-community/mathlib4#659 * `algebra.hom.units`: leanprover-community/mathlib4#745 * `algebra.ring.basic`: leanprover-community/mathlib4#830 * `category_theory.natural_isomorphism`: leanprover-community/mathlib4#820 * `combinatorics.quiver.connected_component`: leanprover-community/mathlib4#836 * `combinatorics.quiver.subquiver`: leanprover-community/mathlib4#828 Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mathlib3 SHA: 8c53048add6ffacdda0b36c4917bfe37e209b0ba