feat(algebra/hom/centroid): Commutative Centroid of a *-ring is a *-ring #6595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
1 task
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
mans0954
added
the
awaiting-review
eric-wieser
reviewed
Aug 15, 2023
eric-wieser
reviewed
Aug 15, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This reverts commit 27acbde.
mans0954
commented
Aug 16, 2023
Mathlib/Algebra/Hom/Centroid.lean
Outdated
| @@ -542,7 +542,8 @@ def star_ring (mul_comm : ∀ f g : CentroidHom α, f * g = g * f) : StarRing (C | |||
| star_mul := fun f g => by | |||
| rw [mul_comm] | |||
| ext | |||
| rw [star_apply, mul_apply, mul_apply, star_apply, star_apply, star_star] | |||
| rw [star_apply, mul_apply, mul_apply, star_apply] | |||
| simp | |||
There was a problem hiding this comment.
In the lean3 version of this PR https://github.com/leanprover-community/mathlib/pull/18096/files#diff-b9e451cbb3a5b6efa050e64d3f4896b5d3ed3c51e9f034259709f8372aaaa525R342 I could close the goal with
rw [star_apply, mul_apply, mul_apply, star_apply, star_apply, star_star]
But doing this in Mathlib4 results in:
Build: Mathlib/Algebra/Hom/Centroid.lean#L538
(deterministic) timeout at 'whnf', maximum number of heartbeats (200000) has been reached (use 'set_option maxHeartbeats <num>' to set the limit)
eric-wieser
reviewed
Aug 16, 2023
eric-wieser
reviewed
Aug 16, 2023
mans0954
added
awaiting-review
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
Import summaryDependency changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows that if the centroid of a *-ring is commutative then it is a *-ring.
Previously submitted to mathlib as leanprover-community/mathlib#18096