Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Analysis/NormedSpace/MatrixExponential): remove Lean 3 TC workarounds #6608

Conversation

eric-wieser
Copy link
Member

The file still compiles without these, so I guess as predicted we no longer need them. They were certainly needed in Lean 3.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Aug 16, 2023
@mcdoll
Copy link
Member

mcdoll commented Aug 16, 2023

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by mcdoll.

@ocfnash
Copy link
Contributor

ocfnash commented Aug 16, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 16, 2023
bors bot pushed a commit that referenced this pull request Aug 16, 2023
…rounds (#6608)

The file still compiles without these, so I guess as predicted we no longer need them. They were certainly needed in Lean 3.
@bors
Copy link

bors bot commented Aug 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Analysis/NormedSpace/MatrixExponential): remove Lean 3 TC workarounds [Merged by Bors] - chore(Analysis/NormedSpace/MatrixExponential): remove Lean 3 TC workarounds Aug 16, 2023
@bors bors bot closed this Aug 16, 2023
@bors bors bot deleted the eric-wieser/matrix-exponential-instance-hack-removal branch August 16, 2023 12:08
semorrison pushed a commit that referenced this pull request Aug 17, 2023
…rounds (#6608)

The file still compiles without these, so I guess as predicted we no longer need them. They were certainly needed in Lean 3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants