Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: two missing lemmas about restricting continuous maps #6616

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat: two missing lemmas about restricting continuous maps #6616

wants to merge 3 commits into from

Conversation

ADedecker
Copy link
Member

Open in Gitpod

@ADedecker ADedecker added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels Aug 16, 2023
@ADedecker ADedecker mentioned this pull request Aug 16, 2023
Closed
1 task
@dagurtomas
Copy link
Collaborator

Looks good to me -- works well in the implementation of LocallyConstant.piecewise' in #6589.

ocfnash
ocfnash approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Topology/Constructions.lean Show resolved Hide resolved
Mathlib/Topology/Constructions.lean Show resolved Hide resolved
Mathlib/Topology/Constructions.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Aug 19, 2023

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Aug 19, 2023
@ADedecker @ocfnash
Apply suggestions from code review
ff89986 
Co-authored-by: Oliver Nash <github@olivernash.org>
@ADedecker
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 19, 2023
bors bot pushed a commit that referenced this pull request Aug 19, 2023
@ADedecker
feat: two missing lemmas about restricting continuous maps (#6616)
a0d8b86
@bors
Copy link

bors bot commented Aug 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: two missing lemmas about restricting continuous maps [Merged by Bors] - feat: two missing lemmas about restricting continuous maps Aug 19, 2023
@bors bors bot closed this Aug 19, 2023
@bors bors bot deleted the AD_continuous_restrict branch August 19, 2023 14:39
dagurtomas added a commit that referenced this pull request Aug 19, 2023
@dagurtomas
merge #6616
1692e2e
bors bot pushed a commit that referenced this pull request Sep 28, 2023
@dagurtomas
feat: LocallyConstant.piecewise' (#6589)
2f22e29 
We define a variant of `LocallyConstant.piecewise` which defines a locally constant map on a subset given locally constant maps on two closed subsets covering it, that agree on the intersection.

-  [x] depends on: #6616 

Co-authored-by: Anatole Dedecker @ADedecker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocfnash ocfnash ocfnash approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ADedecker @dagurtomas @ocfnash @leanprover-community-mathlib4-bot