New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Data/Matrix/Invertible): generalize conjugate and transpose lemmas #6618
Conversation
These lemmas are more general than the one about `nonsing_inv`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Personally I'd excise transposeInvertibleEquivInvertible
but I'll let you make the call.
bors d+
/-- Together `Matrix.invertibleTranspose` and `Matrix.invertibleOfInvertibleTranspose` form an | ||
equivalence, although both sides of the equiv are subsingleton anyway. -/ | ||
@[simps] | ||
def transposeInvertibleEquivInvertible : Invertible Aᵀ ≃ Invertible A where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this equiv. Will it ever be used except for your proof of isUnit_transpose
below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, but this result is one that we already had in the other file, and I've somewhat established this pattern across the matrix inversion bits of the library, even though I admit it's not a very nice one.
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
…mas (#6618) The `conjTranspose` lemmas now work for non-commutative rings.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
The
conjTranspose
lemmas now work for non-commutative rings.