Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Data/Matrix/Invertible): generalize conjugate and transpose lemmas #6618

Closed
wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Aug 16, 2023

The conjTranspose lemmas now work for non-commutative rings.


Open in Gitpod

These lemmas are more general than the one about `nonsing_inv`
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Aug 16, 2023
@eric-wieser eric-wieser changed the title feat(Data/Matrix/Invertible): inverse of conjugate and transpose chore(Data/Matrix/Invertible): generalize conjugate and transpose lemmas Aug 16, 2023
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Personally I'd excise transposeInvertibleEquivInvertible but I'll let you make the call.

bors d+

/-- Together `Matrix.invertibleTranspose` and `Matrix.invertibleOfInvertibleTranspose` form an
equivalence, although both sides of the equiv are subsingleton anyway. -/
@[simps]
def transposeInvertibleEquivInvertible : Invertible Aᵀ ≃ Invertible A where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this equiv. Will it ever be used except for your proof of isUnit_transpose below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not, but this result is one that we already had in the other file, and I've somewhat established this pattern across the matrix inversion bits of the library, even though I admit it's not a very nice one.

@bors
Copy link

bors bot commented Aug 23, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Aug 23, 2023
@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 23, 2023
bors bot pushed a commit that referenced this pull request Aug 23, 2023
…mas (#6618)

The `conjTranspose` lemmas now work for non-commutative rings.
@bors
Copy link

bors bot commented Aug 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Data/Matrix/Invertible): generalize conjugate and transpose lemmas [Merged by Bors] - chore(Data/Matrix/Invertible): generalize conjugate and transpose lemmas Aug 23, 2023
@bors bors bot closed this Aug 23, 2023
@bors bors bot deleted the eric-wieser/matrix-invertible-transpose branch August 23, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants