Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: ordered monoid instances for lexicographic order on Prod, Pi, Finsupp and DFinsupp #6625

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: ordered monoid instances for lexicographic order on Prod, Pi, Finsupp and DFinsupp #6625

wants to merge 6 commits into from

Conversation

alreadydone
Copy link
Contributor

Open in Gitpod

@alreadydone alreadydone added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Aug 17, 2023
@alreadydone alreadydone marked this pull request as ready for review August 17, 2023 05:27
@alreadydone alreadydone mentioned this pull request Aug 17, 2023
Open
3 tasks
eric-wieser
eric-wieser approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed some changes to use where in more places, please revert if you dislike them.

bors d+

@bors
Copy link

bors bot commented Aug 18, 2023

✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Aug 18, 2023
@alreadydone
Copy link
Contributor Author

Thanks! Learnt a new syntax :)

bors r+

bors bot pushed a commit that referenced this pull request Aug 18, 2023
@alreadydone @eric-wieser
feat: ordered monoid instances for lexicographic order on Prod, Pi, F…
ffc1e0b 
…insupp and Dfinsupp (#6625)





Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@alreadydone alreadydone changed the title feat: ordered monoid instances for lexicographic order on Prod, Pi, Finsupp and Dfinsupp feat: ordered monoid instances for lexicographic order on Prod, Pi, Finsupp and DFinsupp Aug 18, 2023
@bors
Copy link

bors bot commented Aug 18, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: ordered monoid instances for lexicographic order on Prod, Pi, Finsupp and DFinsupp [Merged by Bors] - feat: ordered monoid instances for lexicographic order on Prod, Pi, Finsupp and DFinsupp Aug 18, 2023
@bors bors bot closed this Aug 18, 2023
@bors bors bot deleted the OrderedMonoidLex branch August 18, 2023 17:06
@alreadydone alreadydone restored the OrderedMonoidLex branch August 18, 2023 22:08
@alreadydone alreadydone deleted the OrderedMonoidLex branch August 18, 2023 22:21
@alreadydone alreadydone restored the OrderedMonoidLex branch August 20, 2023 04:43
@alreadydone alreadydone reopened this Aug 20, 2023
@bors bors bot deleted the OrderedMonoidLex branch August 20, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alreadydone @eric-wieser @leanprover-community-mathlib4-bot