New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(Algebra/Lie/BaseChange): use new tensor product machinery #6628
Conversation
eric-wieser
commented
Aug 17, 2023
It's great that this works but given how slow it is, it seems like we're still not ready to use |
I managed to speed it up, I didn't need the heterobasic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, now that this is not too slow, I think it's worth doing this to have an application of TensorProduct.AlgebraTensorModule.tensorTensorTensorComm
.
It looks like further golfing is now possible (we should no longer need both bracket_tmul'
and bracket_tmul
and even bracket_def
should not be necessary) but I don't think it's worth spending more time on this.
bors merge
There's always #6306 if you want another one :) |
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |