Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: missing results about StarAlgHom.codRestrict #6668

Closed
wants to merge 4 commits into from

Conversation

ADedecker
Copy link
Member

This is a step towards making sure that all the codRestrict APIs are similar, but they're still not similar enough in wether they take bundled subobjects/morphisms or subobject/morphism classes.


Noticed while reviewing #6372

Open in Gitpod

StarAlgHom.ext fun _ => rfl

@[simp]
theorem coe_codRestrict (f : A →⋆ₐ[R] B) (S : StarSubalgebra R B) (hf : ∀ x, f x ∈ S) (x : A) :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
theorem coe_codRestrict (f : A →⋆ₐ[R] B) (S : StarSubalgebra R B) (hf : ∀ x, f x ∈ S) (x : A) :
theorem codRestrict_apply (f : A →⋆ₐ[R] B) (S : StarSubalgebra R B) (hf : ∀ x, f x ∈ S) (x : A) :

since this mentions x (this also matches LinearMap.codRestrict_apply)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more important that it mirrors AlgHom.coe_codRestrict and NonUnitalStarAlgHom.coe_codRestrict. At some point we want to have a full look at the whole library and make sure that everything is consistent.
I'm going to open issue about that, but I think I prefer to keep this name for now if you think that's okay.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, actually I guess these should be called coe_codRestrict_apply, since the coercion is Subtype.val not just FunLike.coe. But yes, I'm fine leaving the name as is in light of my comment below.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Aug 19, 2023

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Aug 19, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@ADedecker
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 20, 2023
bors bot pushed a commit that referenced this pull request Aug 20, 2023
This is a step towards making sure that all the `codRestrict` APIs are similar, but they're still not similar enough in wether they take bundled subobjects/morphisms or subobject/morphism classes.
@bors
Copy link

bors bot commented Aug 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: missing results about StarAlgHom.codRestrict [Merged by Bors] - feat: missing results about StarAlgHom.codRestrict Aug 20, 2023
@bors bors bot closed this Aug 20, 2023
@bors bors bot deleted the AD_starAlgHom_codRestrict branch August 20, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants