Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: drop MulZeroClass. in mul_zero/zero_mul #6682

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 19, 2023

Search&replace MulZeroClass.mul_zero -> mul_zero, MulZeroClass.zero_mul -> zero_mul.

These were introduced by Mathport, as the full name of mul_zero is actually MulZeroClass.mul_zero (it's exported with the short name).


Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI labels Aug 19, 2023
@eric-wieser
Copy link
Member

bors d+

Thanks! I edited the description with a brief explanation.

@bors
Copy link

bors bot commented Aug 19, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR awaiting-CI labels Aug 19, 2023
@urkud
Copy link
Member Author

urkud commented Aug 19, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 19, 2023
bors bot pushed a commit that referenced this pull request Aug 19, 2023
Search&replace `MulZeroClass.mul_zero` -> `mul_zero`, `MulZeroClass.zero_mul` -> `zero_mul`.

These were introduced by Mathport, as the full name of `mul_zero` is actually `MulZeroClass.mul_zero` (it's exported with the short name).
@bors
Copy link

bors bot commented Aug 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: drop MulZeroClass. in mul_zero/zero_mul [Merged by Bors] - chore: drop MulZeroClass. in mul_zero/zero_mul Aug 19, 2023
@bors bors bot closed this Aug 19, 2023
@bors bors bot deleted the YK-mul-zero branch August 19, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants