Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(LinearAlgebra/DFinsupp): remove dependency on Basis #6706

Closed
wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

The motivation here is to explore re-defining Basis with DFinsupp instead of Finsupp, in order to make it computable.


Open in Gitpod

The motivation here is to explore re-defining `Basis` with `DFinsupp` instead of `Finsupp`, in order to make it computable.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Aug 21, 2023
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good plan, but please don't forget to fix the build errors!

Mathlib/LinearAlgebra/FinsuppVectorSpace.lean Outdated Show resolved Hide resolved
@eric-wieser eric-wieser changed the title choreLinearAlgebra/DFinsupp): remove dependency on Basis chore(LinearAlgebra/DFinsupp): remove dependency on Basis Sep 11, 2023
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@eric-wieser
Copy link
Member Author

@Vierkantor: CI is happy

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Sep 12, 2023
bors bot pushed a commit that referenced this pull request Sep 12, 2023
The motivation here is to explore re-defining `Basis` with `DFinsupp` instead of `Finsupp`, in order to make it computable.
@bors
Copy link

bors bot commented Sep 12, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 12, 2023
The motivation here is to explore re-defining `Basis` with `DFinsupp` instead of `Finsupp`, in order to make it computable.
@bors
Copy link

bors bot commented Sep 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(LinearAlgebra/DFinsupp): remove dependency on Basis [Merged by Bors] - chore(LinearAlgebra/DFinsupp): remove dependency on Basis Sep 12, 2023
@bors bors bot closed this Sep 12, 2023
@bors bors bot deleted the eric-wieser/move-Basis-dependency branch September 12, 2023 14:06
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
The motivation here is to explore re-defining `Basis` with `DFinsupp` instead of `Finsupp`, in order to make it computable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants