Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: further theory about the Killing form of Lie algebras #6737

Closed
wants to merge 29 commits into from
Closed

[Merged by Bors] - feat: further theory about the Killing form of Lie algebras #6737

wants to merge 29 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Aug 22, 2023 •
edited by github-actions bot

ocfnash and others added 26 commits August 10, 2023 17:19
@ocfnash
feat: define the star structure on the group algebra
5c9c807 
And use it to define the substitution `T ↦ T⁻¹` on Laurent polynomials.
@ocfnash
Golf MonoidAlgebra.instStarRing
38b1f8e
@ocfnash
Merge branch 'master' into ocfnash/star_laurent
8ce1d28
@ocfnash
Remove global instances and provide algebra equivalences.
33fe16e
@ocfnash
Reimplement using MonoidAlgebra.mapDomainAlgEquiv
42b51b7
@ocfnash
Doc string should emphasise invert not instStarRing
ab8b7e3
@ocfnash
Update Mathlib/Algebra/MonoidAlgebra/Star.lean
90dcca0
@ocfnash
Add doc strings
c565434
@ocfnash
Small extension to API for LaurentPolynomial.invert
2f46695
@ocfnash
feat: characterise the reverse of the characteristic polynomial of a …
0df098a 
…matrix
@ocfnash @eric-wieser
Update Mathlib/Data/Polynomial/Laurent.lean
c9c3287 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@ocfnash
merge master
15fa96b
@ocfnash
Excise old construction of inversion
08853c2
@ocfnash
Scope notation and fix after merging master
9a024d4
@ocfnash
Extra lemma suggestions from CR
a308cfd
@ocfnash @adomani
feat: nilpotent matrices have nilpotent trace
72a5c2a 
Also some related results

Co-authored-by: damiano <adomani@gmail.com>
@ocfnash
Fixes after adding simp to card_ne_zero and redefining `Polynomia…
3912b90 
…l.coeff_one`
@ocfnash
Drop simp on Matrix.trace_fin_zero
b8e2d6a 
IMHO there's a strong case for deleting this lemma entirely.
@ocfnash
merge master
e3e14ca
@ocfnash
Drop Matrix.charpoly_def
1adbdde 
The was dropped as part of CR in a dependent PR and only accidentally
brought back by git.
@ocfnash
Tidy up
03adba0
@ocfnash
Merge branch 'master' into ocfnash/nilpotent_charpoly
f1beef2
@ocfnash
feat: lemmas about Smith normal form and trace of restriction
509d3a4
@ocfnash
Appease linter
86a7df2
@ocfnash
Fix up after merge
000c37a
@ocfnash
feat: further theory about the Killing form of Lie algebras
a207b71
@ocfnash ocfnash added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Aug 22, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Aug 22, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Sep 4, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 4, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 4, 2023
@ocfnash ocfnash removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 4, 2023
jcommelin
jcommelin approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors d+

Mathlib/Algebra/Lie/Killing.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/Killing.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 4, 2023

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ocfnash
Copy link
Contributor Author

ocfnash commented Sep 4, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 4, 2023
bors bot pushed a commit that referenced this pull request Sep 4, 2023
@ocfnash
feat: further theory about the Killing form of Lie algebras (#6737)
e92aa3c
@bors
Copy link

bors bot commented Sep 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: further theory about the Killing form of Lie algebras [Merged by Bors] - feat: further theory about the Killing form of Lie algebras Sep 4, 2023
@bors bors bot closed this Sep 4, 2023
@bors bors bot deleted the ocfnash/restr_killing2 branch September 4, 2023 22:30
ebab pushed a commit that referenced this pull request Sep 6, 2023
@ocfnash @ebab
feat: further theory about the Killing form of Lie algebras (#6737)
a84dd78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocfnash @leanprover-community-mathlib4-bot @jcommelin