[Merged by Bors] - feat(RingTheory/FiniteType): generalize results to non-commutative generators #6757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
alexjbest
reviewed
Aug 24, 2023
| @[simp] | ||
| theorem adjoin_range_ι : Algebra.adjoin R (Set.range (ι R : X → FreeAlgebra R X)) = ⊤ := by | ||
| set S := Algebra.adjoin R (Set.range (ι R : X → FreeAlgebra R X)) | ||
| refine top_unique fun x hx => ?_; clear hx |
There was a problem hiding this comment.
Why do you need to clear hx here, out of curiosity?
There was a problem hiding this comment.
I just copied this from the MvPolynomial proof (along with the rest of the proof)
leanprover-community-mathlib4-bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
…nerators (#6757) Many of the proofs in this file go via quotients of `MvPolynomial`; but this forces a commutativity assumption that can be avoided by instead going via quotients of `FreeAlgebra`. Most of the new `FreeAlgebra` results are just copies of the proofs for `MvPolynomial`, which isn't ideal in terms of duplication.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
ebab
pushed a commit
that referenced
this pull request
Sep 6, 2023
…nerators (#6757) Many of the proofs in this file go via quotients of `MvPolynomial`; but this forces a commutativity assumption that can be avoided by instead going via quotients of `FreeAlgebra`. Most of the new `FreeAlgebra` results are just copies of the proofs for `MvPolynomial`, which isn't ideal in terms of duplication.
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
…nerators (#6757) Many of the proofs in this file go via quotients of `MvPolynomial`; but this forces a commutativity assumption that can be avoided by instead going via quotients of `FreeAlgebra`. Most of the new `FreeAlgebra` results are just copies of the proofs for `MvPolynomial`, which isn't ideal in terms of duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the proofs in this file go via quotients of
MvPolynomial; but this forces a commutativity assumption that can be avoided by instead going via quotients ofFreeAlgebra.Most of the new
FreeAlgebraresults are just copies of the proofs forMvPolynomial, which isn't ideal in terms of duplication.